Update tarball hash for 810 again (we had to merge a few more fixes to scip for 810)

conda-forge / scipoptsuite-feedstock

A conda-smithy repository for scipoptsuite.

BSD 3-Clause "New" or "Revised" License

25 stars 13 forks source link

Update tarball hash for 810 again (we had to merge a few more fixes to scip for 810) #51

Closed ju-manns closed 11 months ago

ju-manns commented 11 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'papilo' output doesn't have any tests.
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-webservices[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-webservices[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'papilo' output doesn't have any tests.
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

AntoinePrv commented 11 months ago

@ju-manns if 8.1.0 is released, the artifact on scipopt.org must not change. You should instead bump bugfix 8.1.1 > 8.1.2 > ... We won't be running out of numbers anytime soon ;)

ju-manns commented 11 months ago

@AntoinePrv Ah, I was not aware. Does that mean that all past artifacts on scipopt.org should remain available? In that case, we would have to do a SCIP 8.1.1 release too (no big overhead there).

AntoinePrv commented 11 months ago

I mean the Conda packages will be fine, but in general (and this is relevant also outside of Conda), once you make a release it's frozen for eternity.

One reason is reproducibility. Even if you think it's the same, it may change something for someone somewhere. The other is security/integrity. Hash mismatch are meant to indicate a corrupt download, either fraudulent or broken.