Add thewchan to maintainers

conda-forge / scipy-feedstock

A conda-smithy repository for scipy.

BSD 3-Clause "New" or "Revised" License

6 stars 36 forks source link

Closed thewchan closed 3 years ago

thewchan commented 3 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

thewchan commented 3 years ago

Hey folks, another package need v1.5.4 as a dependency, wonder if I can be added to try to add that version to the repo

rgommers commented 3 years ago

HI @thewchan, why do you need to be added for that? Can't you just submit a PR that adds a 1.5.4 build?

Also, out of curiosity, what package is that?

thewchan commented 3 years ago

Oh if I don't need to be added to do that then that's fine, it's just I was under the impression I needed to be added. I can just submit a PR then.

rgommers commented 3 years ago

Oh if I don't need to be added to do that then that's fine, it's just I was under the impression I needed to be added.

You don't need to be, so I'll close this PR.

The package is this: https://github.com/shankarpandala/lazypredict

thanks

h-vetinari commented 3 years ago

I created a branch v1.5 that you should git checkout and target your PR against (when opening it).