Rerendered - Githubissues

conda-forge / sdl2_image-feedstock

A conda-smithy repository for sdl2_image.

BSD 3-Clause "New" or "Revised" License

1 stars 7 forks source link

Rerendered #11

Closed dschreij closed 1 year ago

dschreij commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

a-hurst commented 2 years ago

@dschreij To fix the SPDX thing, just replace "ZLIB" with "Zlib" as the licence in the meta.yml. That's what I needed to do for the PySDL2 feedstock, anyway.

EDIT: Oh, wait, I thought it was the linter failing and not the linux build.

EDIT 2: Wait, command "make" not found? That sounds like an upstream Conda CI problem.

dschreij commented 2 years ago

Thanks. The reason why it's failing now though is because it suddenly can't find make for the Linux build, so I will need to see how to add this in the recipe

h-vetinari commented 1 year ago

Closing as obsolete (fixed by #12)