sfml v2.6.1 - Githubissues

conda-forge / sfml-feedstock

A conda-smithy repository for sfml.

BSD 3-Clause "New" or "Revised" License

0 stars 5 forks source link

sfml v2.6.1 #11

Closed cNoNim closed 8 months ago

cNoNim commented 8 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

I tried to rerender but https://github.com/conda-forge/conda-smithy/issues/1549 Guess: @conda-forge-admin, please rerender

conda-forge-webservices[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

github-actions[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/sfml-feedstock/actions/runs/7700097567.

github-actions[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/sfml-feedstock/actions/runs/7700104206.

cNoNim commented 8 months ago

Why Re-render downgrade year in LICENSE.txt? PS: but guess, this does not affect the current PR

cNoNim commented 8 months ago

@conda-forge-admin, please rerender

cNoNim commented 8 months ago

@conda-forge-admin, please rerender

cNoNim commented 8 months ago

@martinRenou Can you advise me on MACOSX_DEPLOYMENT_TARGET/MACOSX_SDK_VERSION or do I need to ping core?

conda-forge-webservices[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

cNoNim commented 8 months ago

@conda-forge-admin, please rerender

cNoNim commented 8 months ago

I'll ask a question for the future Is it legal?

azure:
  store_build_artifacts: true

It would be very convenient. The local build is a bit buggy on windows.

martinRenou commented 8 months ago

Can you advise me on MACOSX_DEPLOYMENT_TARGET/MACOSX_SDK_VERSION or do I need to ping core?

I'm not sure about this! So pinging core or asking on https://app.gitter.im/#/room/#conda-forge_conda-forge.github.io:gitter.im may be better

martinRenou commented 8 months ago

Thanks for getting this green!

It looks good to me. I'm not familiar with providing a recipe/conda_build_config.yaml though. Would be nice to get validation from a conda-forge team.

cNoNim commented 8 months ago

@conda-forge-admin, please ping conda-forge/core

conda-forge-webservices[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/core and so here I am doing that.

xhochy commented 8 months ago

Raising the SDK version is fine

cNoNim commented 8 months ago

@martinRenou Can you "Approve" review?