conda-forge / sgp4-feedstock

A conda-smithy repository for sgp4.
BSD 3-Clause "New" or "Revised" License
0 stars 6 forks source link

Rebuild for python 3.13 #47

Closed regro-cf-autotick-bot closed 1 week ago

regro-cf-autotick-bot commented 2 months ago

This PR has been triggered in an effort to update python313.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

jochym commented 2 months ago

@brandon-rhodes we have a doctest failure on Intel. OSX/arm passes. Strange. Would you take a look?

brandon-rhodes commented 2 months ago

@brandon-rhodes we have a doctest failure on Intel. OSX/arm passes. Strange. Would you take a look?

Yes, I'll try looking tomorrow. It looks like the problem might not be 3.13, but a change in NumPy's behavior — it looks like set_printoptions() might now return a non-None value, so the doctest fails because there's now printed output below that line instead of nothing printed.

How can I learn which version of NumPy is now in use?

jochym commented 2 months ago

We have numpy 1.22, 1.23, 1.26 and numpy 2 - they ar ein the name of the test process. The particular numpy version depends on the platform. But this look like not connected with one numpy version.

brandon-rhodes commented 2 months ago

We have numpy 1.22, 1.23, 1.26 and numpy 2 - they ar ein the name of the test process. The particular numpy version depends on the platform. But this look like not connected with one numpy version.

It looks like the NumPy version named in the test process is not the NumPy version getting used? For example:

"linux linux_64_numpy1.22 failed" https://github.com/conda-forge/sgp4-feedstock/pull/47/checks?check_run_id=29590907757

Yet:

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1017116&view=logs&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=6d4b912b-175d-51da-0fd9-4d30fe1eb4e7&l=893

numpy:            2.1.0-py312h58c1407_1      conda-forge
brandon-rhodes commented 2 months ago

For what it's worth, the breaking change in 2.1.0 is being fixed:

https://github.com/numpy/numpy/pull/27255

jochym commented 2 months ago

I will take a second look this evening.

jochym commented 2 weeks ago

@conda-forge-admin, please rerender

conda-forge-admin commented 2 weeks ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition. I do have some suggestions for making it better though...

For recipe/meta.yaml:

conda-forge-admin commented 2 weeks ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.