Closed regro-cf-autotick-bot closed 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged.
I think the recent release of pytest broke the call to py.test
in the test script.
Hi! This is the friendly conda-forge automerge bot!
Commits were made to this PR after the automerge
label was added. For security reasons, I have disabled automerge by removing the automerge
label. Please add the automerge
label again (or ask a maintainer to do so) if you'd like to enable automerge again!
@mwtoews, seems to have worked for CPython! But not PyPy. Any ideas there?
It was failing before with PyPy, except that the return code was never checked! I've refactored run_test.py a bit further to skip tests with "strtree".
The only other failure is with osx osx_arm64_numpy1.23python3.11.____cpython
On PyPy it's failing the vectorized tests as well:
__________________ ERROR collecting tests/test_vectorized.py ___________________
tests/test_vectorized.py:5: in <module>
import shapely.vectorized
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/pypy3.8/site-packages/shapely/vectorized/__init__.py:5: in <module>
from ._vectorized import (contains, touches)
shapely/vectorized/_vectorized.pyx:1: in init shapely.vectorized._vectorized
???
E ValueError: array.array size changed, may indicate binary incompatibility. Expected 72 from C header, got 24 from PyObject
But that seems a signal of some build issue?
test_vectorized was failing before too, so it's not new. Further up in the log there are some stern warnings about shapely.speedups and shapely.vectorized being ignored.
The vectorized and speedups code gets skipped on purpose for PyPy because PyPy's just-in-time compiling does essentially the same thing. So it just make sense to skip the tests as you're doing. Thanks for this work @mwtoews!
somehow it seems that --continue-on-collection-errors
broke win and osx pypy tests, as they are all hanging after showing "tests/test_point.py ..................... [ 63%]".
I could re-instate the previous logic to ignore the return code from pytest for PyPy tests.
@mwtoews, I'm good with you doing whatever you think is best to get us through the pypy tests, whether that's skipping more tests or just ignoring them entirely. It seems like testing is just generally iffy when one skips vectorized and speedups.
Also for shapely 2.0 (on the dev branch here), we just run pytest from within meta.yml, and thus could remove this file. So I wouldn't put too much effort in improving the run_test.py file. If it was skipping the check for pypy, let's maybe just leave it like that for now?
@conda-forge-admin please rerender
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/shapely-feedstock/actions/runs/3340835977.
Pytest results are now skipped, as it was before, so the PyPy issues are "resolved".
There is only some flaky failures with osx_arm64, previously it was with osx_arm64_numpy1.23python3.11.cpython, and now it is with osx_arm64_numpy1.21python3.10.cpython (/Users/runner/miniforge3/conda-bld/shapely_1666903085007/_build_env/etc/conda/activate.d/activate_z-cross-python_osx-arm64.sh: line 1: ��: No such file or directory
)
Is there a work-around for dealing with random failures with osx_arm64?
None that I'm aware of. I'd merge (since it's definitely unrelated to the changes here) and we can retrigger builds as necessary if they fail after merge.
Am watching main branch builds and will restart as I see failures.
This PR has been triggered in an effort to update python311.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3332037550, please use this URL for debugging.