Closed regro-cf-autotick-bot closed 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Not looking good in terms of failing tests. Anyone have any insight? I didn't see any discussion upstream yet about GEOS 3.12.0.
Sorry, didn't search far enough. Presumably some patching with these tests is needed: https://github.com/shapely/shapely/pull/1820
Anyone have time to take that on?
It might be a bit too much work to add a patch to fix the test (while ideally we would do a new release upstream instead). Short term, maybe easier to skip the tests that are known to fail? Looking at the build output, all failures are known ones (and while it looks there are many, it's mostly from a few heavily parametrized tests)
Should we just skip the tests for now?
@mahf708, if you have time to skip the failing tests, I would support that. I haven't had time and won't today.
@mahf708, since you're not currently a maintainer here, you might need to open a new PR.
Yep, will do. No worries, @xylar 😄
I can add a commit here to skip tests, but would like to see an updated build first
@conda-forge-admin please rerender
Oh, there's more troubles here than just skipping tests, cython build fails
Error compiling Cython file:
------------------------------------------------------------
...
self.last_error = <char *> malloc((1025) * sizeof(char))
self.last_error[0] = 0
self.last_warning = <char *> malloc((1025) * sizeof(char))
self.last_warning[0] = 0
GEOSContext_setErrorMessageHandler_r(
self.handle, &geos_message_handler, self.last_error
^
------------------------------------------------------------
shapely/_geos.pyx:30:25: Cannot assign type 'void (*)(const char *, void *) except *' to 'GEOSMessageHandler_r'
Error compiling Cython file:
------------------------------------------------------------
...
self.last_warning[0] = 0
GEOSContext_setErrorMessageHandler_r(
self.handle, &geos_message_handler, self.last_error
)
GEOSContext_setNoticeMessageHandler_r(
self.handle, &geos_message_handler, self.last_warning
That might be a cython 3 failure? (I think we haven't yet tested explicitly since the cython release, so would not be surprised)
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
requirements: build: cython<3
must contain a space between the name and the pin, i.e. cython <3
requirements: host: cython<3
must contain a space between the name and the pin, i.e. cython <3
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin please rerender
@conda-forge/shapely Anybody else wish to sign off on this?
Le Sigh, I jinxed myself. Sorry, will boggle some more.
Thank you @akrherz! I'm sorry for not having time to contribute.
This PR has been triggered in an effort to update geos3120.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5403417259, please use this URL for debugging.