conda-forge / shapely-feedstock

A conda-smithy repository for shapely.
BSD 3-Clause "New" or "Revised" License
9 stars 20 forks source link

ARM OSX Migrator #81

Closed regro-cf-autotick-bot closed 3 years ago

regro-cf-autotick-bot commented 3 years ago

This feedstock is being rebuilt as part of the ARM OSX migration.

Feel free to merge the PR if CI is all green, but please don't close it without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/563164437, please use this URL for debugging

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar commented 3 years ago

@conda-forge-admin, please restart ci

xylar commented 3 years ago

The build error message is:

/Users/runner/miniforge3/conda-bld/shapely_1616054025545/_build_env/bin/cython: line 4: import: command not found
/Users/runner/miniforge3/conda-bld/shapely_1616054025545/_build_env/bin/cython: line 5: import: command not found
from: can't read /var/mail/Cython.Compiler.Main
/Users/runner/miniforge3/conda-bld/shapely_1616054025545/_build_env/bin/cython: line 10: syntax error near unexpected token `('
/Users/runner/miniforge3/conda-bld/shapely_1616054025545/_build_env/bin/cython: line 10: `    sys.argv[0] = re.sub(r'(-script\.pyw?|\.exe)?$', '', sys.argv[0])'
Traceback (most recent call last):
  File "/Users/runner/miniforge3/bin/conda-build", line 11, in <module>
    sys.exit(main())
  File "/Users/runner/miniforge3/lib/python3.8/site-packages/conda_build/cli/main_build.py", line 481, in main
    execute(sys.argv[1:])
  File "/Users/runner/miniforge3/lib/python3.8/site-packages/conda_build/cli/main_build.py", line 470, in execute
    outputs = api.build(args.recipe, post=args.post, test_run_post=args.test_run_post,
  File "/Users/runner/miniforge3/lib/python3.8/site-packages/conda_build/api.py", line 186, in build
    return build_tree(
  File "/Users/runner/miniforge3/lib/python3.8/site-packages/conda_build/build.py", line 3068, in build_tree
    packages_from_this = build(metadata, stats,
  File "/Users/runner/miniforge3/lib/python3.8/site-packages/conda_build/build.py", line 2191, in build
    utils.check_call_env(cmd, env=env, rewrite_stdout_env=rewrite_env,
  File "/Users/runner/miniforge3/lib/python3.8/site-packages/conda_build/utils.py", line 412, in check_call_env
    return _func_defaulting_env_to_os_environ('call', *popenargs, **kwargs)
  File "/Users/runner/miniforge3/lib/python3.8/site-packages/conda_build/utils.py", line 392, in _func_defaulting_env_to_os_environ
    raise subprocess.CalledProcessError(proc.returncode, _args)
subprocess.CalledProcessError: Command '['/bin/bash', '-o', 'errexit', '/Users/runner/miniforge3/conda-bld/shapely_1616054025545/work/conda_build.sh']' returned non-zero exit status 2.
##[error]Bash exited with code '1'.

It seems like cython is messing up somehow at a very basic level.

ocefpaf commented 3 years ago

@isuruf does that error make sense to you?

jonathanmccormack commented 3 years ago

It looks like calling cython from the build script is for whatever reason executing /Users/runner/miniforge3/conda-bld/shapely_1616054025545/_build_env/bin/cython with bash and not as a python script. I get the same errors when I try to force bash to run ./bin/cython:

$ bash /opt/homebrew/Caskroom/miniforge/base/bin/cython
/opt/homebrew/Caskroom/miniforge/base/bin/cython: line 4: import: command not found
/opt/homebrew/Caskroom/miniforge/base/bin/cython: line 5: import: command not found
from: can't read /var/mail/Cython.Compiler.Main
/opt/homebrew/Caskroom/miniforge/base/bin/cython: line 10: syntax error near unexpected token `('
/opt/homebrew/Caskroom/miniforge/base/bin/cython: line 10: `    sys.argv[0] = re.sub(r'(-script\.pyw?|\.exe)?$', '', sys.argv[0])'

I would assume that the first line of /Users/runner/miniforge3/conda-bld/shapely_1616054025545/_build_env/bin/cython would need to be:

#!/Users/runner/miniforge3/conda-bld/shapely_1616054025545/_build_env/bin/python

...or whatever the correct path in Azure pipelines is to the python installed by conda in the earlier steps.

xhochy commented 3 years ago

@conda-forge/shapely This is ready for review/merge.

xylar commented 3 years ago

If others want to weight in, do so soon. Otherwise I'll merge tomorrow morning.

ocefpaf commented 3 years ago

If others want to weight in, do so soon. Otherwise I'll merge tomorrow morning.

LGTM. Thanks so much @isuruf and @xylar for fixing this one. @xylar, merge away!