search

conda-forge / shapely-feedstock

A conda-smithy repository for shapely.
BSD 3-Clause "New" or "Revised" License
9 stars 20 forks source link

GEOS 3.10 #89

Closed bretttully closed 3 years ago

bretttully commented 3 years ago

I was attempting to try out the new shapely release with the new geos release, but it appears that shapely has a minor pin restriction on geos 3.9.1. Is that expected?

mamba create -n gis -c conda-forge "shapely>=1.8" "geos>=3.10"

Fails with

Encountered problems while solving:
  - package shapely-1.8.0-py37h48c49eb_0 requires geos >=3.9.1,<3.9.2.0a0, but none of the providers can be installed
bretttully commented 3 years ago

Looking at the CI build, you can see it pinned geos=3.9.1 here

akrherz commented 3 years ago

Awaiting migrator to come, see conda-forge/conda-forge-pinning-feedstock#2051

bretttully commented 3 years ago

Aha. I was searching around in this feedstock to see where it was being set, but I think it just highlighted my superficial understanding of the beauty that is conda-forge build+pins infra.

akrherz commented 3 years ago

Aha. I was searching around in this feedstock to see where it was being set, but I think it just highlighted my superficial understanding of the beauty that is conda-forge build+pins infra.

It is the 8th wonder of the modern world! The reason for the tight pinning is shown here: api laboratory.

bretttully commented 3 years ago

Cool, thanks @akrherz, I'll watch that PR and try again once it's merged

akrherz commented 3 years ago

I'll watch that PR and try again once it's merged

FYI, once it is merged, then another bot process eventually runs which submits a PR to this feedstock repo, once that PR is vetted and merged, then a new build is uploaded to conda-forge repo, then you can try installing it!

jorisvandenbossche commented 3 years ago

Is there a reason to wait with merging the migration PR? (I am not familiar with the process to decide on that)

akrherz commented 3 years ago

Is there a reason to wait with merging the migration PR? (I am not familiar with the process to decide on that)

I think it a matter of letting the bots do the work, and/or there's additional dependency packages that need to finish migrating first and/or the conda-forge folks are waiting for the api-laboratory website to update with the geos 3.10 report and/or folks are busy :)

Manually doing the migration just for shapely is possible, but then dll-hell happens I suspect and folks can't just update shapely+geos without taking the entire python GIS stack with it :)

I'm interested in helping this through, so will see if we can get the bots started on this task.

dopplershift commented 3 years ago

Yeah, you can update manually, but then you'll have a shapely package that will only work with other libraries compiled against GEOS 3.10--which don't exist until someone updates them. That's why we have a migrator bot. 😉

jorisvandenbossche commented 3 years ago

To be clear I didn't mean to go forward with just shapely as a special case, I was asking about merging the migration PR so the automatic migration could get started. Now, in the meantime that is already done, and there new shapely packages are already uploaded! (https://github.com/conda-forge/shapely-feedstock/pull/90)