conda-forge / shapely-feedstock

A conda-smithy repository for shapely.
BSD 3-Clause "New" or "Revised" License
9 stars 20 forks source link

Rebuild for python310 #91

Closed regro-cf-autotick-bot closed 3 years ago

regro-cf-autotick-bot commented 3 years ago

This PR has been triggered in an effort to update python310.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1429170421, please use this URL for debugging

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar commented 3 years ago

tests/test_geomseq.py . [ 22%] Fatal Python error: Segmentation fault

I'll see if this is a known issue in the shapely dev. repo.

xylar commented 3 years ago

Doesn't look like it. I'm traveling right now. Anyone else have time to report this (or debug it)?

jorisvandenbossche commented 3 years ago

It seems the crash only happens on the OSX + Python 3.10 combination (and using the basic OSX, not arm64)? I don't have a Mac myself to help debugging (there are also no tests using Mac in the shapely repo itself at the moment ..).

Based on the log output, the failure seems to come from test_error_handler_exception (https://github.com/Toblerity/Shapely/blob/d6f72e2d645b2bc8f1d75233b8facc345bdc735a/tests/test_geos_err_handler.py#L10), which tries to read an invalid WKT string.

jorisvandenbossche commented 3 years ago

If there is not directly someone who can investigate, could we either merge this anyway as is (and skip that test?) or merge with skipping MacOS? (then we would at least have Python 3.10 packages for the other OSs)

xylar commented 3 years ago

Let's see if skipping that test does the trick.

jorisvandenbossche commented 3 years ago

Hmm, seems there are more crashes, and now in more essential functionality (test_invalid_intersection). So maybe we should first investigate this .. (and for this PR skip the build on osx-64 for python 3.10 altogether?)

xylar commented 3 years ago

Yep, that works for me.

xylar commented 3 years ago

@conda-forge-admin, please rerender

jorisvandenbossche commented 3 years ago

Thanks! In the meantime I have opened an issue on the Shapely side to investigate the crashes: https://github.com/Toblerity/Shapely/issues/1227

phobson commented 3 years ago

I have a Mac running Mac OS 11.6. Should I run the shapely tests in a fresh Python 3.10 environment? Latest shapely release or dev?

jorisvandenbossche commented 3 years ago

@phobson Yes, installing the latest release (1.8.0; the dev branch already changed a lot) in a Python 3.10 environment and then run the tests. That would be super helpful! (we can further discuss at https://github.com/Toblerity/Shapely/issues/1227)

dopplershift commented 3 years ago

I'm not sure merging this with no 3.10 & osx support did any good since any downstream package that has osx builds won't get migrated until the package is available.

jorisvandenbossche commented 3 years ago

Sorry, I am not very aware of how those bots get triggered (but not merging this at all also would prevent downstream packages to get migrated, right?)

xylar commented 3 years ago

Sorry, @dopplershift. You're right that partial python 3.10 support isn't really more useful than just holding off, particularly because it's confusing for downstream packages.

dopplershift commented 3 years ago

It's not a problem, but I just wanted to clarify for future migrations (because I only corrected my own understanding recently). IIUC, the bot checks that all the builds can be resolved before issuing the PRs. The ramifications of merging this missing osx is just that the downstream builds show up as "not solvable" rather than "awaiting parents" on the status page.

@jorisvandenbossche To be clear, the only way to get downstream packages migrated (assuming they support osx), is to get all the packages built.