Closed akrherz closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I didn't get anywhere, but did setup a local reproducer on an old Mac I have. I did also try the shapely main branch, which will pass all tests except one if I comment out the stray import pylab
in the examples (no conda-forge matplotlib yet).
ERROR: test_polygon_3 (tests.test_singularity.PolygonTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/akrherz/Shapely/tests/test_singularity.py", line 14, in test_polygon_3
poly = Polygon([p, p, p])
File "/Users/akrherz/Shapely/shapely/geometry/polygon.py", line 251, in __new__
geom = pygeos.polygons(shell, holes=holes)
File "/Users/akrherz/miniconda3/envs/py310/lib/python3.10/site-packages/pygeos/decorators.py", line 80, in wrapped
return func(*args, **kwargs)
File "/Users/akrherz/miniconda3/envs/py310/lib/python3.10/site-packages/pygeos/creation.py", line 235, in polygons
geometries = linearrings(geometries)
File "/Users/akrherz/miniconda3/envs/py310/lib/python3.10/site-packages/pygeos/decorators.py", line 80, in wrapped
return func(*args, **kwargs)
File "/Users/akrherz/miniconda3/envs/py310/lib/python3.10/site-packages/pygeos/creation.py", line 157, in linearrings
return lib.linearrings(coords, out=out, **kwargs)
ValueError: A linearring requires at least 4 coordinates.
can debug this more now locally.
and needed an excuse to be added as a maintainer
Feel free to open a separate PR just for that :)
I did also try the shapely main branch
The main branch is basically a complete rewrite of the low-level code (no longer using ctypes), so for figuring out those segfaults for 1.8, you will need to test with the 1.8 tag or maint-1.8
branch
Did you succeed to reproduce the segfaults?
Did you succeed to reproduce the segfaults?
Indeed, but no resolution yet.
Hi @akrherz @jorisvandenbossche Is there any news on that? Thanks!
XRef: This is currently blocking the migration of cartopy
(https://github.com/conda-forge/cartopy-feedstock/issues/131).
Not yet. The root cause is an issue in the Python / libffi build, and that is being discussed here: https://github.com/conda-forge/python-feedstock/issues/522
Thanks for the pointer, much appreciated.
@conda-forge-admin restart ci
Hi! This is the friendly automated conda-forge-linting service.
I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Exciting times for a Friday evening, awaiting python-3.10.0-h1248fe1_3_cpython.tar.bz2
and the like to appear in repo metadata!
@akrherz, I restarted CI. Fingers crossed.
We're good! Thank you @akrherz, @jorisvandenbossche, @dopplershift and others for tracking this down!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)I'm interested in the segfaults issue from #91 and needed an excuse to be added as a maintainer :) Pardon the noise.