search

conda-forge / shogun-cpp-feedstock

A conda-smithy repository for shogun-cpp.
BSD 3-Clause "New" or "Revised" License
0 stars 7 forks source link

Add MKL variant #23

Closed djsutherland closed 4 years ago

djsutherland commented 6 years ago

https://github.com/conda-forge/staged-recipes/pull/6715

cc @vigsterkr

djsutherland commented 6 years ago

I think, though am not 100% clear, that legally we need to not distribute the GPL components when we're linking against MKL.

vigsterkr commented 6 years ago

@dougalsutherland there's yet another reason why it should be a separate formula

vigsterkr commented 6 years ago

as we can just disable the GPL part with LICENSE_GPL_SHOGUN=OFF

djsutherland commented 6 years ago

We can do that as part of the variant too.

vigsterkr commented 4 years ago

can be closed, fixed in https://github.com/conda-forge/shogun-cpp-feedstock/pull/34