Use conda-forge's default Fortran compiler on Windows

conda-forge / slycot-feedstock

A conda-smithy repository for slycot.

BSD 3-Clause "New" or "Revised" License

1 stars 12 forks source link

Use conda-forge's default Fortran compiler on Windows #65

Closed bnavigator closed 11 months ago

bnavigator commented 11 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed) (no)
[X] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Avoid specifying flang (see https://github.com/conda-forge/blas-feedstock/issues/106)

conda-forge-webservices[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bnavigator commented 11 months ago

@conda-forge-admin, please rerender

roryyorke commented 11 months ago

Will try to look this weekend, unfortunately can't promise that I will.

On Thu, 19 Oct 2023, 12:38 Ben Greiner, @.***> wrote:

@bnavigator https://github.com/bnavigator requested your review on: #65 https://github.com/conda-forge/slycot-feedstock/pull/65 Use conda-forge's default Fortran compiler on Windows as a code owner.

— Reply to this email directly, view it on GitHub https://github.com/conda-forge/slycot-feedstock/pull/65#event-10708468721, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA3C7TDCZOLO5I5EKDPF63YAD7JTAVCNFSM6AAAAAA6G5U4ICVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQG4YDQNBWHA3TEMI . You are receiving this because your review was requested.Message ID: @.***>

moorepants commented 11 months ago

This seems fine to me. The use of flang in the past is because there may have not been a default fortran compiler on windows.

bnavigator commented 11 months ago

Yes, that's what I understand from the comments in https://github.com/conda-forge/blas-feedstock/issues/106 as well. We added the flang >= 11 two years ago, but the comments in https://github.com/conda-forge/slycot-feedstock/pull/39, https://github.com/conda-forge/slycot-feedstock/pull/36 and https://github.com/python-control/Slycot/pull/160 did not record why exactly.

bnavigator commented 11 months ago

I pressed merge and the main branch is updated. Somehow Github got confused a bit in the process. If this doesn't get resolved automatically, I will close manually in a bit.