search

conda-forge / snowflake-connector-python-feedstock

A conda-smithy repository for snowflake-connector-python.
BSD 3-Clause "New" or "Revised" License
5 stars 14 forks source link

Rebuild for python311 #119

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

This PR has been triggered in an effort to update python311.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3345832145, please use this URL for debugging.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hajapy commented 1 year ago

Looks like cryptograph requirement will be relaxed in a future version: https://github.com/snowflakedb/snowflake-connector-python/pull/1266 but is causing a problem here. We could probably loosen the upper bound now as it doesn't look like the upstream package needed to change any functionality for the looser requirement range.

hajapy commented 1 year ago

Ah well this will fail pip check. I happened to notice cryptography 38.0.2, which is the only one we have rebuilt for py311, is presently yanked from pypi: https://pypi.org/project/cryptography/38.0.2 see: https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst#3802---2022-10-11-yanked. Issue filed: https://github.com/conda-forge/cryptography-feedstock/issues/108

h-vetinari commented 1 year ago

Ah well this will fail pip check.

Yes, for that you'd have to patch the source requirements. There's no risk in doing that, cryptography has a very stable API.

h-vetinari commented 1 year ago

There's no risk in doing that, cryptography has a very stable API.

OK, for full transparency, there are occasional API changes (removed deprecations etc.), but if the package runs fine (e.g. tests run through), it should be fine to use a newer cryptography.