conda-forge / snowflake-snowpark-python-feedstock

A conda-smithy repository for snowflake-snowpark-python.
BSD 3-Clause "New" or "Revised" License
2 stars 5 forks source link

Arch Migrator #51

Closed regro-cf-autotick-bot closed 2 months ago

regro-cf-autotick-bot commented 2 months ago

This feedstock is being rebuilt as part of the aarch64/ppc64le migration.

Feel free to merge the PR if CI is all green, but please don't close it without reaching out the the ARM migrators first at @conda-forge/arm-arch.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/10603607149 - please use this URL for debugging.

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

sfc-gh-yuwang commented 2 months ago

@conda-forge-admin please rerender

github-actions[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/snowflake-snowpark-python-feedstock/actions/runs/10619245635.

sfc-gh-yuwang commented 2 months ago

@xhochy Hi, can you help take a look at this automated PR? It seems like I need to change the conda-forge.yml file but I don't have the permission. Thank you!

sfc-gh-mkeller commented 2 months ago

What just happened with the Travis CI build?

hmaarrfk commented 2 months ago

your package is effective a "python: noarch" with a constraint that makes it only installable on python 3.9.

why have all these different builds?

Consider

build:
  - noarch: python
requirements:
  host:
    - python >=3.9,<3.10.0a0
  run:
    - python >=3.9,<3.10.0a0
    - cloudpickle >=1.6.0,<=2.2.1,!=2.1.0,!=2.2.0

and it will all become 1 job.

sfc-gh-mkeller commented 2 months ago

@hmaarrfk We already do and should continue to be building Python 3.8-3.11 packages and in this PR we want to add support for ARM on Linux too. According to the conda-forge docs this package doesn't qualify to be a noarch package, since it has a Python version dependent dependency.

hmaarrfk commented 2 months ago

Sorry about that, I got confused by the skip statement.

Why do you have this requirement?

    - cloudpickle >=1.6.0,<=2.2.1,!=2.1.0,!=2.2.0  # [py<311]
    - cloudpickle >=2.2.1,<3.0.0  # [py==311]

could it just be removed?

hmaarrfk commented 2 months ago

@conda-forge-admin please restart cis

hmaarrfk commented 2 months ago

@conda-forge-admin please rerender

hmaarrfk commented 2 months ago

if the py==311 stuff can be removed, your whole build matrix collapses to 1.

sfc-gh-mkeller commented 2 months ago

if the py==311 stuff can be removed, your whole build matrix collapses to 1.

Sorry about that, I got confused by the skip statement.

Why do you have this requirement?

    - cloudpickle >=1.6.0,<=2.2.1,!=2.1.0,!=2.2.0  # [py<311]
    - cloudpickle >=2.2.1,<3.0.0  # [py==311]

could it just be removed?

No, unfortunately not in the short-term. I checked in with the devs and some versions don't work well on Python 3.8 and 3.9, but that newer version is actually the only thing working on 3.11. They are on removing these, but we'd like to get a Linux ARM build out before that happens.

sfc-gh-mkeller commented 2 months ago

@hmaarrfk also would you know why Python 3.8 builds were removed?

hmaarrfk commented 2 months ago

We dropped support for it at conda-forge like last week.

sfc-gh-mkeller commented 2 months ago

@hmaarrfk Also, wouldn't we have to increase the build number, or will forge just add the new files only?

hmaarrfk commented 2 months ago

If the ci support files don't change. It's pretty safe.

We will only upload files that change hash.

For this migration it is likely pretty safe.

sfc-gh-mkeller commented 2 months ago

Alright then, thank you s much @hmaarrfk for your help!