Updated recipe for version 2.0.0

conda-forge / sparqlwrapper-feedstock

A conda-smithy repository for sparqlwrapper.

BSD 3-Clause "New" or "Revised" License

0 stars 9 forks source link

Updated recipe for version 2.0.0 #26

Closed rfm-targa closed 1 year ago

rfm-targa commented 1 year ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [12]

rfm-targa commented 1 year ago

@conda-forge-admin, please rerender

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

rfm-targa commented 1 year ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/sparqlwrapper-feedstock/actions/runs/3469561543.

rfm-targa commented 1 year ago

@conda-forge-admin, please rerender

bollwyvl commented 1 year ago

Frankly I thought this project was dead: thanks for freshening it up, please ping me if you need additional help getting it to work. You should also likely add yourself as one of the maintainers, if you're a user of if!

bollwyvl commented 1 year ago

@conda-forge-admin please rerender

bollwyvl commented 1 year ago

Also recommend:

test:
  requires:
    - pip
  imports:
    - SPARQLWrapper
  commands:
    - pip check
    - rqw --help

rfm-targa commented 1 year ago

Also recommend:

test:
  requires:
    - pip
  imports:
    - SPARQLWrapper
  commands:
    - pip check
    - rqw --help

Thank you for noticing that those basic tests were missing.

bollwyvl commented 1 year ago

Everything looks solid now, but I would again suggest adding yourself as a maintainer (and asking for a re-render from the bot), then pinging the team, a la @conda-forge/sparqlwrapper ready for review... that way, if you get no response for a few days (usually a full week), then the core team can be asked to force merge.

rfm-targa commented 1 year ago

@conda-forge-admin, please rerender

bollwyvl commented 1 year ago

@conda-forge/sparqlwrapper ready for review :rocket:

rfm-targa commented 1 year ago

@bollwyvl thank you for all the valuable suggestions.

bollwyvl commented 1 year ago

@conda-forge-admin please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/sparqlwrapper-feedstock/actions/runs/3518878734.

bollwyvl commented 1 year ago

@conda-forge/core please consider merging this, no word back from @conda-forge/sparqlwrapper for a week.