search

conda-forge / spikingjelly-feedstock

A conda-smithy repository for spikingjelly.
BSD 3-Clause "New" or "Revised" License
0 stars 3 forks source link

Patching setup.py not required #1

Closed carterbox closed 2 years ago

carterbox commented 2 years ago

Hi @Tobias-Fischer,

I noticed that you are patching this package to prevent pip from installing dependencies. This patch is not required. Just add the --no-deps option to pip install. Consider removing this patch during the next rebuild.

https://pip.pypa.io/en/stable/cli/pip_install/#cmdoption-no-deps

Cheers!

Tobias-Fischer commented 2 years ago

Hiya, thanks for this! Are you happy to open a pull request?

Tobias-Fischer commented 2 years ago

I think the issue is that the requirements.txt does not exist in the package, and that it'll still try to read it in the setup.py even with no-deps

carterbox commented 2 years ago

I think the issue is that the requirements.txt does not exist in the package, and that it'll still try to read it in the setup.py even with no-deps

Oh! You're right. I didn't realize that the pypi source distribution was incomplete. I was looking at the source directly on GitHub.