conda-forge / spirv-tools-feedstock

A conda-smithy repository for spirv-tools.
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Update version to 2024.1 #12

Closed ZzEeKkAa closed 4 months ago

ZzEeKkAa commented 4 months ago

Checklist

Closes: #9 Closes: #10 Closes: #11

conda-forge-webservices[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ZzEeKkAa commented 4 months ago

@conda-forge-admin, please rerender

ZzEeKkAa commented 4 months ago

From the error log:

/Users/runner/miniforge3/conda-bld/spirv-tools_1716652032354/work/tools/objdump/objdump.cpp:64:20: error: 'path' is unavailable: introduced in macOS 10.15 - see https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk

It looks like package requires macOS 15 +, but I'm not sure how to add exception to the generated recipes...

hmaarrfk commented 4 months ago

See these 4 lines.

https://github.com/conda-forge/opencv-feedstock/blob/5fba48ab99792965c420f5387909a96105e82d11/recipe/conda_build_config.yaml#L4

You should be able to search our documentation for them to better understand.

ZzEeKkAa commented 4 months ago

Thank you @hmaarrfk ! I guess I found better solution in the doc: https://conda-forge.org/docs/maintainer/knowledge_base/#newer-c-features-with-old-sdk

So the CI is green now and ready to merge.

hmaarrfk commented 4 months ago

Add yourself as a maintainer ;) and rerender?

ZzEeKkAa commented 4 months ago

@conda-forge-admin, please rerender

hmaarrfk commented 4 months ago

Thank you

ZzEeKkAa commented 4 months ago

@hmaarrfk why did not it uploaded to the conda-forge channel? https://anaconda.org/conda-forge/spirv-tools/files

hmaarrfk commented 4 months ago

i'm not sure. i retriggered a build by just pushing to main.

while frowned upon, it is "ok" in these scenerios...

https://github.com/conda-forge/spirv-tools-feedstock/runs/25528205184

hmaarrfk commented 4 months ago

seems like the builds are now uploading.

ZzEeKkAa commented 4 months ago

Thank you!