search

conda-forge / spirv-tools-feedstock

A conda-smithy repository for spirv-tools.
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

rebuild with conda-forge spirv-headers #7

Closed conda-forge-admin closed 11 months ago

conda-forge-admin commented 11 months ago

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #6.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

conda-forge-webservices[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 11 months ago

there didn't seem to be an easy way to get around this....

isuruf commented 11 months ago

there didn't seem to be an easy way to get around this....

I don't understand

hmaarrfk commented 11 months ago

I tried to get around the cmake flags, and eventually i found that I had to comment out the cmake stuff. however, some definition isn't found now, so I have to investigate a little further.

This is the cmake section, i felt like it would have been appropriate to just remove it

https://github.com/KhronosGroup/SPIRV-Tools/blob/v2023.2/external/CMakeLists.txt#L29

but it seems like the external package is actually doing something more.

hmaarrfk commented 11 months ago

thanks for finding that.

I'm finding other strange things in the build logs:

[03:15:52][ERROR   ] Failed to run "['git', 'describe']" in "/home/conda/feedstock_root/build_artifacts/spirv-tools_1697426009897/work": fatal: No names found, cannot describe anything.
hmaarrfk commented 11 months ago

Building the other architectures https://github.com/conda-forge/spirv-headers-feedstock/pull/7

hmaarrfk commented 11 months ago

@conda-forge-admin please rerender

github-actions[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/spirv-tools-feedstock/actions/runs/6528852573.

hmaarrfk commented 11 months ago

ok, i'm not entirely sure about hte windows bug, but it will be for an other day for me.

github-actions[bot] commented 11 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!