Fix issue where retrieving menuinst version resulted in an error

mrclary commented 1 month ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Fixes spyder-ide/spyder#22566 Fixes spyder-ide/spyder#22565

Do not check menuinst version for conda-based apps. This is not necessary and circumvents any inconsistencies with CONDA_PYTHON_EXE introduced by constructor at install time.
Do not create shortcut if there is an error retrieving the menuinst version. This should catch any error due to CONDA_PYTHON_EXE or if menuinst is not installed.

github-actions[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

mrclary commented 1 month ago

@ccordoba12 @dalthviz, we should be able to release a build-1 with this PR and then just try to re-run the failed jobs https://github.com/spyder-ide/spyder/actions/runs/11005699855/job/30559245423#step:14:835

ccordoba12 commented 1 month ago

Ok, sounds good to me. Thanks Ryan for your work on this.

github-actions[bot] commented 1 month ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

conda-forge / spyder-feedstock