Update application system identifiers

conda-forge / spyder-feedstock

A conda-smithy repository for spyder.

BSD 3-Clause "New" or "Revised" License

1 stars 17 forks source link

Update application system identifiers #190

Closed mrclary closed 1 month ago

mrclary commented 1 month ago

Change app_user_model_id, StartupWMClass, and CFBundleIdentifier to include Spyder major version and (possibly) environment name. This should ensure uniqueness if multiple instances of Spyder are installed. Note CFBundleIdentifier cannot contain underscores.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

github-actions[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

hmaarrfk commented 1 month ago

Could we try to also pull in https://github.com/conda-forge/spyder-feedstock/pull/177/commits/134afb66edd1671cf590aad847b304edda42abb1 to reduce the builds from 22 to 3?

ccordoba12 commented 1 month ago

Change app_user_model_id, StartupWMClass, and CFBundleIdentifier to include Spyder major version and (possibly) environment name.

Does this affect the app main window title? I think it does on Linux, but please check in all OSes to be sure.

Could we try to also pull in https://github.com/conda-forge/spyder-feedstock/commit/134afb66edd1671cf590aad847b304edda42abb1 to reduce the builds from 22 to 3?

Done in PR #191. Thanks for your patience with that @hmaarrfk.

hmaarrfk commented 1 month ago

no issue, just trying to help keep down the maintenance of this feedstock. New python versions, new architechtures, this project is already hard enough ;)

ccordoba12 commented 1 month ago

this project is already hard enough ;)

Haha, totally! And we really appreciate your help to simplify our workflow in Conda-forge 👍🏽

hmaarrfk commented 1 month ago

seems like you added some new qt5, linux64 only features, so this is back to a arch dependent package.

ccordoba12 commented 1 month ago

@mrclary, I left this question for you in https://github.com/conda-forge/spyder-feedstock/pull/190#issuecomment-2381432916:

Does this affect the app main window title? I think it does on Linux, but please check in all OSes to be sure.

mrclary commented 1 month ago

@mrclary, I left this question for you in #190 (comment):

Does this affect the app main window title? I think it does on Linux, but please check in all OSes to be sure.

I'm currently verifying... Sorry for not letting you know.

mrclary commented 1 month ago

I've checked on all three platforms (Linux, macOS, and Windows) that these changes do not affect the application name as seen by the user and only impact file-type association.