Closed mrclary closed 1 week ago
@conda-forge-admin, please rerender
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11671887584.
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml
) and found it was in an excellent condition.
@mrclary, did you manually check that this fixes the problem for old menuinst
versions?
Just in case, I think there is a config (store_build_artifacts
) that can be set to enable downloading the package as an Azure pipeline artifact (https://conda-forge.org/docs/maintainer/conda_forge_yml/#azure). Maybe it could be worthy to enable that to check changes to the feedstock on PRs?
@mrclary, did you manually check that this fixes the problem for old
menuinst
versions?
Not yet.
Just in case, I think there is a config (
store_build_artifacts
) that can be set to enable downloading the package as an Azure pipeline artifact (https://conda-forge.org/docs/maintainer/conda_forge_yml/#azure). Maybe it could be worthy to enable that to check changes to the feedstock on PRs?
That would be very useful. Do we need to make that change in a separate PR and merge that in first, or can that be included in the current PR?
That would be very useful. Do we need to make that change in a separate PR and merge that in first, or can that be included in the current PR?
I think doing the change here should trigger the upload here but if that doesn't work we can try opening a PR only for that and then updating this one after that gets merged :+1:
I think doing the change here should trigger the upload here but if that doesn't work we can try opening a PR only for that and then updating this one after that gets merged 👍
I'll give a try.
@dalthviz @ccordoba12 I don't see any artifacts on Azure. Did I do something wrong?
@conda-forge-admin, please rerender
Maybe a rerender is necessary?
Maybe a rerender is necessary?
That seemed to work. I can download artifacts!
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:
host
section of the recipe, you should almost always use python {{ python_min }}.*
for the python
entry. You may need to override the python_min
variable if the package requires a newer Python version than the currently supported minimum version on conda-forge
.run
section of the recipe, you should almost always use python >={{ python_min }}
for the python
entry. You may need to override the python_min
variable if the package requires a newer Python version than the currently supported minimum version on conda-forge
.test.requires
section of the recipe, you should almost always use python ={{ python_min }}
for the python
entry. You may need to override the python_min
variable if the package requires a newer Python version than the currently supported minimum version on conda-forge
.@conda-forge-admin, please rerender
@mrclary, did you manually check that this fixes the problem for old
menuinst
versions?
I've now tested on my Windows VM. With menuinst=1.4.20
and the build artifact, Spyder installs without error and the shortcuts are created.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Fixes spyder-ide/spyder#22790