conda-forge / spyder-feedstock

A conda-smithy repository for spyder.
BSD 3-Clause "New" or "Revised" License
1 stars 17 forks source link

Fix typo in menuinst v1 json file #198

Closed mrclary closed 1 week ago

mrclary commented 1 week ago

Checklist

Fixes spyder-ide/spyder#22790

mrclary commented 1 week ago

@conda-forge-admin, please rerender

conda-forge-admin commented 1 week ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition. I do have some suggestions for making it better though...

For recipe/meta.yaml:

conda-forge-admin commented 1 week ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11671887584.

conda-forge-admin commented 1 week ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

ccordoba12 commented 1 week ago

@mrclary, did you manually check that this fixes the problem for old menuinst versions?

dalthviz commented 1 week ago

Just in case, I think there is a config (store_build_artifacts) that can be set to enable downloading the package as an Azure pipeline artifact (https://conda-forge.org/docs/maintainer/conda_forge_yml/#azure). Maybe it could be worthy to enable that to check changes to the feedstock on PRs?

mrclary commented 1 week ago

@mrclary, did you manually check that this fixes the problem for old menuinst versions?

Not yet.

Just in case, I think there is a config (store_build_artifacts) that can be set to enable downloading the package as an Azure pipeline artifact (https://conda-forge.org/docs/maintainer/conda_forge_yml/#azure). Maybe it could be worthy to enable that to check changes to the feedstock on PRs?

That would be very useful. Do we need to make that change in a separate PR and merge that in first, or can that be included in the current PR?

dalthviz commented 1 week ago

That would be very useful. Do we need to make that change in a separate PR and merge that in first, or can that be included in the current PR?

I think doing the change here should trigger the upload here but if that doesn't work we can try opening a PR only for that and then updating this one after that gets merged :+1:

mrclary commented 1 week ago

I think doing the change here should trigger the upload here but if that doesn't work we can try opening a PR only for that and then updating this one after that gets merged 👍

I'll give a try.

mrclary commented 1 week ago

@dalthviz @ccordoba12 I don't see any artifacts on Azure. Did I do something wrong?

ccordoba12 commented 1 week ago

@conda-forge-admin, please rerender

ccordoba12 commented 1 week ago

Maybe a rerender is necessary?

mrclary commented 1 week ago

Maybe a rerender is necessary?

That seemed to work. I can download artifacts!

conda-forge-admin commented 1 week ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition. I do have some suggestions for making it better though...

For recipe/meta.yaml:

mrclary commented 1 week ago

@conda-forge-admin, please rerender

mrclary commented 1 week ago

@mrclary, did you manually check that this fixes the problem for old menuinst versions?

I've now tested on my Windows VM. With menuinst=1.4.20 and the build artifact, Spyder installs without error and the shortcuts are created.