conda-forge / spyder-feedstock

A conda-smithy repository for spyder.
BSD 3-Clause "New" or "Revised" License
1 stars 17 forks source link

Allow PyQt 5.9 from conda-forge #52

Closed grlee77 closed 5 years ago

grlee77 commented 5 years ago

Now that there is a Qt 5.9 on conda-forge we can relax the PyQt <5.7 restriction in this recipe. Otherwise I get an install of version 3.3.1 instead of 3.3.4. I left <5.10 in place in case defaults updates to Qt 5.12 before conda-forge.

I don't recommend merging yet as there seems to be some problem with the Qt 5.9 package on conda-forge (at least for linux). I experienced the following issue and could not use the keyboard at all in the Spyder terminal or editor.

As suggested by @hmaarfk, setting export QT_XKB_CONFIG_ROOT=/usr/share/X11/xkb/ fixes the issue, but I don't think we should require that of users. Once the upstream Qt package has been fixed (see conda-forge/pyqt-feedstock#52), this should be good to go.

Checklist

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 5 years ago

xref: https://github.com/conda-forge/pyqt-feedstock/issues/52

ccordoba12 commented 5 years ago

Thanks @grlee77! This is ready!