conda-forge / staged-recipes

A place to submit conda recipes before they become fully fledged conda-forge feedstocks
https://conda-forge.org
BSD 3-Clause "New" or "Revised" License
710 stars 4.97k forks source link

ROCM packages #10123

Open isuruf opened 5 years ago

isuruf commented 5 years ago
leofang commented 4 years ago

Hi @isuruf Just wanna follow up here. What's the status of CF's support for the ROCm stack? I've been doing some PRs for CuPy and now the expected dependency will expand to almost all packages that you listed except for those with the prefix MI.

isuruf commented 4 years ago

They haven't been updated in a year now. I've dropped support for rocm in the latest LLVM builds because the patches didn't apply. You are welcome to help with updating llvm with the rocm patches.

leofang commented 4 years ago

Haha it's funny that I got similar suggestions from the Numba team (https://github.com/numba/numba/issues/6196). Could you give me a few pointers for how to proceed/what's needed so that I can play around at my spare time?

isuruf commented 4 years ago

:smile: I guess you already got the suggestion to look at https://github.com/RadeonOpenCompute/llvm-project/

leofang commented 4 years ago

Yes I did! I mean the feedstocks. Which should I touch, llvmdev or llvm-meta (or both)? Do I apply the ROCm patches when building LLVM itself? I am unfamiliar with the llvm packages so need to know more.

isuruf commented 4 years ago

You can ignore llvm-meta. I think you need llvmdev-feedstock and clangdev-feedstock

leofang commented 4 years ago

Hi @isuruf I just took a look at llvmdev-feedstock, and I have a few follow-up questions:

  1. How exactly did you do to obtain the big patch https://github.com/conda-forge/llvmdev-feedstock/blob/master/recipe/patches/amd-roc-2.7.0.diff?
  2. I noticed that we stopped applying the ROCm patch since https://github.com/conda-forge/llvmdev-feedstock/pull/85, but why was it? I couldn't find any discussion there.
  3. I think for recent ROCm to work we need LLVM 11.0. Is there any plan? I saw there's a pending PR of yours (https://github.com/conda-forge/llvmdev-feedstock/pull/96) that could bring us closer.
isuruf commented 4 years ago
  1. ROCm's LLVM repository moves with upstream LLVM git repository. So for ROCm 2.7.0 what I did was to figure out which commit they merged from upstream for 2.7.0 (this may not be a release) and then got the diff with that upstream commit. This diff was applied on the release branch. (For clang, what I used was https://github.com/conda-forge/clangdev-feedstock/blob/master/recipe/patches/amd-roc-hcc-2.7.0.diff#L1-L7)

  2. No time

  3. LLVM 11.0.0.rc3 will be released soon. Only 3 blockers right now.

DanielWicz commented 1 year ago

Is conda roc dead ?