conda-forge / staged-recipes

A place to submit conda recipes before they become fully fledged conda-forge feedstocks
https://conda-forge.org
BSD 3-Clause "New" or "Revised" License
692 stars 4.73k forks source link

Add Dispenso #26729

Closed jeongseok-meta closed 2 weeks ago

jeongseok-meta commented 2 weeks ago

Checklist

conda-forge-webservices[bot] commented 2 weeks ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dispenso) and found it was in an excellent condition.

jeongseok-meta commented 2 weeks ago

@conda-forge/help-c-cpp, ready for review!

wolfv commented 2 weeks ago

Looks good! However, I took a look at the artifact and I think it vendors gtest and gmock:

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=959974&view=logs&j=6f142865-96c3-535c-b7ea-873d86b887bd&t=22b0682d-ab9e-55d7-9c79-49f3c3ba4823&l=2701

Can we disable that?

jeongseok-meta commented 2 weeks ago

Good catch! Fixed it by adding a patch and submitted a PR to the upstream: https://github.com/facebookincubator/dispenso/pull/33

New build log: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=960514&view=logs&j=6f142865-96c3-535c-b7ea-873d86b887bd&t=22b0682d-ab9e-55d7-9c79-49f3c3ba4823&l=2423

wolfv commented 2 weeks ago

awesome!