Add momentum

[jeongseok-meta]

Checklist

• [x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
• [x] License file is packaged (see here for an example).
• [x] Source is from official source.
• [x] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
• [x] If static libraries are linked in, the license of the static library is packaged.
• [x] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
• [x] Build number is 0.
• [x] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
• [x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
• [x] When in trouble, please check our knowledge base documentation before pinging a team.

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/Momentum) and found it was in an excellent condition.

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/Momentum) and found some lint.

Here's what I've got...

For recipes/Momentum:

• requirements: host: ezc3d = "1.5.9.*" should not contain a space between relational operator and the version, i.e. ezc3d ="1.5.9.*"

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/Momentum) and found it was in an excellent condition.

[jeongseok-meta]

@conda-forge/help-c-cpp, ready for review!

[jeongseok-meta]

Is this a header-only library?

It's not: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=969563&view=logs&j=240f1fee-52bc-5498-a14a-8361bde76ba0&t=7c0f8eae-6d6f-51bf-636f-73a1a7fb1bc4&l=2343

[jeongseok-meta]

@xhochy, I have addressed your comment and am ready for a second review. Thank you!

[xhochy]

Is this a header-only library?

It's not: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=969563&view=logs&j=240f1fee-52bc-5498-a14a-8361bde76ba0&t=7c0f8eae-6d6f-51bf-636f-73a1a7fb1bc4&l=2343

Is this a header-only library?

It's not: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=969563&view=logs&j=240f1fee-52bc-5498-a14a-8361bde76ba0&t=7c0f8eae-6d6f-51bf-636f-73a1a7fb1bc4&l=2343

Then please make this output shared libraries (especially on Unix) and add a run_exports.

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/Momentum) and found some lint.

Here's what I've got...

For recipes/Momentum:

• pin_compatible should be used instead of pin_subpackage for Momentum because it is not a known output of this recipe: ['momentum'].

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/Momentum) and found it was in an excellent condition.

[jeongseok-meta]

@conda-forge-admin, please restart ci

[jeongseok-meta]

Build failure on linux64:

CMake Error at /home/conda/staged-recipes/build_artifacts/momentum_1720277066076/_build_env/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find Python3 (missing: Python3_INCLUDE_DIRS Python3_LIBRARIES
  Development Development.Module Development.Embed) (found version "3.12.4")

It fails to find Python3 by find_package(Python3 REQUIRED COMPONENTS Interpreter Development) when python is added to build dependency in meta.yaml:

https://github.com/conda-forge/staged-recipes/pull/26741/files#diff-ca3ef0eb152892ce9d7a357e85c3068cd445fdeb4b40db658c93caa773e2c7f2R23

[jeongseok-meta]

Build failure on osx64:

FAILED: CMakeFiles/simd_constraints.dir/momentum/character_solver/simd_normal_error_function.cpp.o 
$BUILD_PREFIX/bin/x86_64-apple-darwin13.4.0-clang++ -DFMT_SHARED -DMOMENTUM_WITH_SPDLOG=1 -DSPDLOG_COMPILED_LIB -DSPDLOG_FMT_EXTERNAL -DSPDLOG_SHARED_LIB -Dsimd_constraints_EXPORTS -I$SRC_DIR -I$SRC_DIR/build -I$SRC_DIR/axel -I$SRC_DIR/build/axel -isystem $PREFIX/include/eigen3 -isystem $PREFIX/include/dispenso/third-party/moodycamel -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/momentum-0.1.1 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -D_LIBCPP_DISABLE_AVAILABILITY -O3 -DNDEBUG -isysroot /Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -mmacosx-version-min=10.13 -fPIC -march=native -MD -MT CMakeFiles/simd_constraints.dir/momentum/character_solver/simd_normal_error_function.cpp.o -MF CMakeFiles/simd_constraints.dir/momentum/character_solver/simd_normal_error_function.cpp.o.d -o CMakeFiles/simd_constraints.dir/momentum/character_solver/simd_normal_error_function.cpp.o -c $SRC_DIR/momentum/character_solver/simd_normal_error_function.cpp
In file included from $SRC_DIR/momentum/character_solver/simd_normal_error_function.cpp:8:
In file included from $SRC_DIR/momentum/character_solver/simd_normal_error_function.h:13:
$SRC_DIR/momentum/common/aligned.h:42:15: error: reference to unresolved using declaration
  return std::aligned_alloc(align, size);
              ^
$BUILD_PREFIX/bin/../include/c++/v1/cstdlib:148:1: note: using declaration annotated with 'using_if_exists' here
using ::aligned_alloc _LIBCPP_USING_IF_EXISTS;
^
In file included from $SRC_DIR/momentum/character_solver/simd_normal_error_function.cpp:8:
In file included from $SRC_DIR/momentum/character_solver/simd_normal_error_function.h:13:
$SRC_DIR/momentum/common/aligned.h:42:10: error: excess elements in scalar initializer
  return std::aligned_alloc(align, size);
         ^                       ~~~~~~
2 errors generated.

Building it in the upstream CI works fine.

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/Momentum) and found some lint.

Here's what I've got...

For recipes/Momentum:

• If python is a host requirement, it should be a run requirement.
• pin_compatible should be used instead of pin_subpackage for Momentum because it is not a known output of this recipe: ['momentum'].

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/Momentum) and found some lint.

Here's what I've got...

For recipes/Momentum:

• pin_compatible should be used instead of pin_subpackage for Momentum because it is not a known output of this recipe: ['momentum'].

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/Momentum) and found it was in an excellent condition.

[jeongseok-meta]

It seems that it builds multiple times for different python versions (as python is added in to host and run). However, python is only needed during the build process. Is there a more efficient way to handle this instead of adding python to both the host and run dependencies?

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/Momentum) and found some lint.

Here's what I've got...

For recipes/Momentum:

• Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [34, 41]

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/Momentum) and found it was in an excellent condition.

[jeongseok-meta]

@xhochy I have addressed your comments and this pull request is now ready for another review. Thank you for helping to enable building for Linux and macOS!