Add check_shapes - Githubissues

conda-forge / staged-recipes

A place to submit conda recipes before they become fully fledged conda-forge feedstocks

https://conda-forge.org

BSD 3-Clause "New" or "Revised" License

689 stars 4.72k forks source link

Add check_shapes #26762

Closed westinhuang closed 6 days ago

westinhuang commented 1 week ago

Checklist

[x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
[x] License file is packaged (see here for an example).
[x] Source is from official source.
[x] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
[x] If static libraries are linked in, the license of the static library is packaged.
[x] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
[x] Build number is 0.
[x] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
[x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
[x] When in trouble, please check our knowledge base documentation before pinging a team.

Fixes https://github.com/conda-forge/staged-recipes/issues/26766

conda-forge-webservices[bot] commented 1 week ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/check_shapes) and found some lint.

Here's what I've got...

For recipes/check_shapes:

requirements: run: lark >= 1.1.0 should not contain a space between relational operator and the version, i.e. lark >=1.1.0

conda-forge-webservices[bot] commented 1 week ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/check_shapes) and found it was in an excellent condition.

jakirkham commented 1 week ago

Depends on PR: https://github.com/conda-forge/staged-recipes/pull/26765

westinhuang commented 1 week ago

@conda-forge-admin, please restart ci

jakirkham commented 1 week ago

Yeah think it was still mirroring to CDN

@conda-forge-admin , please restart CI

jakirkham commented 1 week ago

Looks ok to me. Let's ask for a 2nd opinion

@conda-forge/staged-recipes could you please review? 🙂

github-actions[bot] commented 1 week ago

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

westinhuang commented 1 week ago

@conda-forge/help-python

westinhuang commented 6 days ago

@ocefpaf It keeps fail.

ocefpaf commented 6 days ago

@ocefpaf It keeps fail.

Yeah. That pattern for multiple outputs is a bit finicky, I used a new one that should be easier to maintain and read.

jakirkham commented 6 days ago

Like the new pattern 🤩

Out of curiosity, does this work better with Grayskull?

ocefpaf commented 6 days ago

Out of curiosity, does this work better with Grayskull?

I don't know. Sadly, Marcello is changing jobs and won't be working on grayskull anytime soon. I'd love to onboard more people to work on recipe updates, multiple outputs, etc. Maybe we should try outreachy again...