add pyairbyte recipe - Githubissues

itsxdamdam commented 3 months ago

Checklist

[x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
[x] License file is packaged (see here for an example).
[x] Source is from official source.
[x] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
[x] If static libraries are linked in, the license of the static library is packaged.
[x] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
[x] Build number is 0.
[x] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
[x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
[x] When in trouble, please check our knowledge base documentation before pinging a team.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (airbyte) and found some lint.

Here's what I've got...

For airbyte:

Please do not delete the example recipe found in recipes/example/meta.yaml.

For airbyte:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (airbyte) and found some lint.

Here's what I've got...

For airbyte:

Please do not delete the example recipe found in recipes/example/meta.yaml.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/airbyte:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

ocefpaf commented 3 months ago

Looks like there are some missing dependencies:

- airbyte-api >=0.49.2,<0.50.0
- ulid >=1.1.0,<2.0.0
- airbyte-cdk >=1.2.1,<2.0.0

You must create package for those too.

itsxdamdam commented 3 months ago

@ocefpaf you mean I have to create these packages in conda-forge before attempting to merge for pyairbyte?

ocefpaf commented 3 months ago

@ocefpaf you mean I have to create these packages in conda-forge before attempting to merge for pyairbyte?

Yep. Those are dependencies and that missing. You can add them here, in the same PR.

itsxdamdam commented 3 months ago

@ocefpaf you mean I have to create these packages in conda-forge before attempting to merge for pyairbyte?

Yep. Those are dependencies and that missing. You can add them here, in the same PR.

I'll get on that now

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/ulid) and found some lint.

Here's what I've got...

For recipes/airbyte:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

For recipes/airbyte-api:

The following maintainers have not yet confirmed that they are willing to be listed here: thesaami. Please ask them to comment on this PR if they are.

For recipes/airbyte-cdk:

The following maintainers have not yet confirmed that they are willing to be listed here: thesaami. Please ask them to comment on this PR if they are.

For recipes/airbyte-protocol-models-pdv2:

The following maintainers have not yet confirmed that they are willing to be listed here: thesaami. Please ask them to comment on this PR if they are.

For recipes/ulid:

The following maintainers have not yet confirmed that they are willing to be listed here: thesaami. Please ask them to comment on this PR if they are.
noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/ulid:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/ulid) and found some lint.

Here's what I've got...

For recipes/ulid:

noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/ulid:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/ulid) and found it was in an excellent condition.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/python-dotenv, recipes/ulid) and found some lint.

Here's what I've got...

For recipes/python-dotenv:

Feedstock with the same name exists in conda-forge.
The following maintainers have not yet confirmed that they are willing to be listed here: thesaami. Please ask them to comment on this PR if they are.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/ulid) and found it was in an excellent condition.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/ulid) and found some lint.

Here's what I've got...

For recipes/airbyte-protocol-models-pdv2:

noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/ulid) and found it was in an excellent condition.

itsxdamdam commented 3 months ago

@ocefpaf I have added all required packages by pyairbyte however, i think this error is from one of the package dependencies and I can't figure it out. Do you mind taking a look?

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/dotenv, recipes/ulid) and found some lint.

Here's what I've got...

For recipes/dotenv:

noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/dotenv, recipes/ulid) and found it was in an excellent condition.

itsxdamdam commented 3 months ago

@conda-forge/help-python I have tried this several times after adding missing packages I'd appreciate it if i can get some help to make all checks successful

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/dotenv, recipes/ulid) and found some lint.

Here's what I've got...

For recipes/airbyte-protocol-models-pdv2:

noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/dotenv, recipes/ulid) and found it was in an excellent condition.

itsxdamdam commented 3 months ago

@conda-forge/help-python

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/ulid, recipes/wcmatch) and found some lint.

Here's what I've got...

For recipes/wcmatch:

The home item is expected in the about section.
Feedstock with the same name exists in conda-forge.

For recipes/wcmatch:

A conda package with same name (wcmatch) already exists.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/ulid) and found it was in an excellent condition.

itsxdamdam commented 3 months ago

@ocefpaf @conda-forge/help-python I’d appreciate any help I can get to fix the failed checks

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/ulid) and found it was in an excellent condition.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/ulid) and found it was in an excellent condition.

ocefpaf commented 3 months ago

@itsxdamdam the logs says:

2024-06-30T20:08:07.2056082Z     File "/home/conda/staged-recipes/build_artifacts/airbyte-protocol-models-pdv2_1719778051249/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/pathlib.py", line 1013, in open
2024-06-30T20:08:07.2063719Z       return io.open(self, mode, buffering, encoding, errors, newline)
2024-06-30T20:08:07.2070819Z              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-06-30T20:08:07.2078302Z   FileNotFoundError: [Errno 2] No such file or directory: '/home/conda/staged-recipes/readme.md'
2024-06-30T20:08:07.2628595Z   error: subprocess-exited-with-error
2024-06-30T20:08:07.2631279Z   
2024-06-30T20:08:07.2631765Z   × Preparing metadata (pyproject.toml) did not run successfully.
2024-06-30T20:08:07.2641830Z   │ exit code: 1
2024-06-30T20:08:07.2642387Z   ╰─> See above for output.

when building airbyte_protocol_models_pdv2 0.12.2. Inspecting the tarball you can see that they are trying to read this file but they are not shipping it in the tarball. Their setup.py has:

# The text of the README file
README = (HERE / "readme.md").read_text()

But that file is nowhere to be seeying. Just download the tarball and inspecr it yourself. This is, sadly, a common bug when people only care about wheels build on their GitHub tree and don't test the tarball. You need to grab that file and/or patch the setup.py to bypass it. But also, please open an issue upstream reporting this bug.

itsxdamdam commented 3 months ago

@itsxdamdam the logs says:
2024-06-30T20:08:07.2056082Z     File "/home/conda/staged-recipes/build_artifacts/airbyte-protocol-models-pdv2_1719778051249/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.12/pathlib.py", line 1013, in open
2024-06-30T20:08:07.2063719Z       return io.open(self, mode, buffering, encoding, errors, newline)
2024-06-30T20:08:07.2070819Z              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-06-30T20:08:07.2078302Z   FileNotFoundError: [Errno 2] No such file or directory: '/home/conda/staged-recipes/readme.md'
2024-06-30T20:08:07.2628595Z   error: subprocess-exited-with-error
2024-06-30T20:08:07.2631279Z   
2024-06-30T20:08:07.2631765Z   × Preparing metadata (pyproject.toml) did not run successfully.
2024-06-30T20:08:07.2641830Z   │ exit code: 1
2024-06-30T20:08:07.2642387Z   ╰─> See above for output.
when building airbyte_protocol_models_pdv2 0.12.2. Inspecting the tarball you can see that they are trying to read this file but they are not shipping it in the tarball. Their setup.py has:
# The text of the README file
README = (HERE / "readme.md").read_text()
But that file is nowhere to be seeying. Just download the tarball and inspecr it yourself. This is, sadly, a common bug when people only care about wheels build on their GitHub tree and don't test the tarball. You need to grab that file and/or patch the setup.py to bypass it. But also, please open an issue upstream reporting this bug.

Ok I'll do that

itsxdamdam commented 3 months ago

@ocefpaf is it okay to attach a modified local tarball file to my PR for this package?

ocefpaf commented 3 months ago

@ocefpaf is it okay to attach a modified local tarball file to my PR for this package?

You should patch the original source, so we can track the changes. Dumping a modified tarball is not OK. An alternative might be using the GH tag instead. See if they provide one with all the required files for the build.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/ulid) and found some lint.

Here's what I've got...

For recipes/airbyte-protocol-models-pdv2:

When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/airbyte, recipes/airbyte-api, recipes/airbyte-cdk, recipes/airbyte-protocol-models-pdv2, recipes/ulid) and found it was in an excellent condition.

itsxdamdam commented 3 months ago

Hi @ocefpaf I tried the alternative using gh tag but I am getting a directory error. I also specified a folder but that didn't solve the problem.

github-actions[bot] commented 3 months ago

Hi! Thanks for your contribution to conda-forge. We appreciate your effort in improving our project. However, it looks like some changes were made outside the recipes directory. To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed. Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR. Thanks!

ocefpaf commented 3 months ago

Hi @ocefpaf I tried the alternative using gh tag but I am getting a directory error. I also specified a folder but that didn't solve the problem.

This is something that you should probably ask upstream. I tried to understand their release methods but I could not make heads or tails of it. I did not understand how the sdist tarball that is on PyPI was generated.

itsxdamdam commented 3 months ago

Hi @ocefpaf I tried the alternative using gh tag but I am getting a directory error. I also specified a folder but that didn't solve the problem.

This is something that you should probably ask upstream. I tried to understand their release methods but I could not make heads or tails of it. I did not understand how the sdist tarball that is on PyPI was generated.

I have made a comment to this effect. Will try again once it is resolved.

conda-forge / staged-recipes

add pyairbyte recipe #26787