add bigquery-magics package

conda-forge / staged-recipes

A place to submit conda recipes before they become fully fledged conda-forge feedstocks

https://conda-forge.org

BSD 3-Clause "New" or "Revised" License

689 stars 4.72k forks source link

add bigquery-magics package #26788

Closed tswast closed 5 days ago

tswast commented 5 days ago

Checklist

[x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
[x] License file is packaged (see here for an example).
[x] Source is from official source.
[x] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
[N/A] If static libraries are linked in, the license of the static library is packaged.
[x] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
[x] Build number is 0.
[x] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
[x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
[ACK] When in trouble, please check our knowledge base documentation before pinging a team.

tswast commented 5 days ago

@conda-forge/help-python, ready for review!

conda-forge-webservices[bot] commented 5 days ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (bigquery-magics) and found some lint.

Here's what I've got...

For bigquery-magics:

Please do not delete the example recipe found in recipes/example/meta.yaml.

tswast commented 5 days ago

Not sure what's going on with the linter. This PR doesn't touch the example folder.

Edit: Moved to recipies/bigquery-magics. Not sure why grayskull didn't put it there.

conda-forge-webservices[bot] commented 5 days ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bigquery-magics) and found it was in an excellent condition.

itsxdamdam commented 5 days ago

Hi @tswast I am having the same errors too Please can you share how you solved it. I'd really appreciate the help

you can find my PR here #26787

ocefpaf commented 5 days ago

Edit: Moved to recipies/bigquery-magics. Not sure why grayskull didn't put it there.

Grayskull creates a directory for your recipe with the recipe's name. It doesn't know about the system where you are.

With that said, the linter message is misleading b/c it thinks you are in the recipe directory and can't see the examples folder. @BastianZim I believe you wrote that lint, right? If not, sorry for the ping.

itsxdamdam commented 5 days ago

thanks @ocefpaf I figured that as well.

However, I still have some errors on check. I'd appreciate it if you can take a look #26787

BastianZim commented 1 day ago

Hi @ocefpaf, yes when it was a GitHub action here but it seems to have been moved to the linter a while ago. I'll have a look, but am limited by train internet currently... Might take a sec.

BastianZim commented 1 day ago

Seems like we have an overlap because this is the one I wrote: https://github.com/conda-forge/staged-recipes/blob/main/.github/workflows/do_not_edit_example.yml

But this one exists as well: https://github.com/conda-forge/conda-smithy/blob/main/conda_smithy/lint_recipe.py#L1215

Where do we prefer it?