conda-forge / staged-recipes

A place to submit conda recipes before they become fully fledged conda-forge feedstocks
https://conda-forge.org
BSD 3-Clause "New" or "Revised" License
701 stars 4.88k forks source link

Adding sixs_json recipe #26803

Closed raphidoc closed 4 weeks ago

raphidoc commented 3 months ago

Checklist

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sixs_json) and found some lint.

Here's what I've got...

For recipes/sixs_json:

For recipes/sixs_json:

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sixs_json) and found it was in an excellent condition.

raphidoc commented 3 months ago

Hi @conda-forge/staged-recipes , @conda-forge/help-fortran, this is my first conda recipe, Ready for review!

It looks like the build failed for win_64 but I was able to build locally on this platform.

This package includes a scientific Fortran software and a light python wrapper.

github-actions[bot] commented 3 months ago

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sixs_json/meta.yaml) and found it was in an excellent condition.

github-actions[bot] commented 1 month ago

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

raphidoc commented 1 month ago

@conda-forge/help-python-c

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sixs_json/meta.yaml) and found some lint.

Here's what I've got...

For recipes/sixs_json/meta.yaml:

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sixs_json/meta.yaml) and found some lint.

Here's what I've got...

For recipes/sixs_json/meta.yaml:

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sixs_json/meta.yaml) and found it was in an excellent condition.

raphidoc commented 1 month ago

Hi @ocefpaf ! When you have some time, can you take a look at this?

ocefpaf commented 1 month ago

Ironically the Windows Fortran part (the harder to get right) seems to be build fine but failing with a file permission error later at install time:

PermissionError: [WinError 5] Access is denied: 'C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmp3gipkosy\\input.json'
Failed to remove a temporary file 'C:\Users\VssAdministrator\AppData\Local\Temp\pip-build-tracker-839rn1dm\8f04c964ef75e25d614a1c7a4e5822bcbc6fea9da6db22a3530b94e4' due to PermissionError: [WinError 5] Access is denied: 'C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pip-build-tracker-839rn1dm\\8f04c964ef75e25d614a1c7a4e5822bcbc6fea9da6db22a3530b94e4'.

Failed to remove a temporary file 'C:\Users\VssAdministrator\AppData\Local\Temp\pip-build-tracker-839rn1dm' due to OSError: [WinError 145] The directory is not empty: 'C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pip-build-tracker-839rn1dm'.

Not sure what is going on.

raphidoc commented 1 month ago

The Python wrapper was installed correctly on Windows using noarch in the meta.yaml (but the Fortran compilation failed on UNIX). So, the easiest way to solve that is to separate the Fortran software and the Python wrapper into two distinct packages. This recipe will keep the modified 6S software (which has now passed all tests !), and I'll create a new one for the Python wrapper. Thank you very much for your help. It's much appreciated :)

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/j6s/meta.yaml, recipes/sixs_json/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/j6s/meta.yaml:

For recipes/sixs_json/meta.yaml:

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/j6s/meta.yaml, recipes/sixs_json/meta.yaml) and found it was in an excellent condition.

raphidoc commented 1 month ago

@ocefpaf I've split this into two packages, and all tests have passed now; this is ready for review and merging!