Add vulkan-volk - Githubissues

conda-forge / staged-recipes

A place to submit conda recipes before they become fully fledged conda-forge feedstocks

https://conda-forge.org

BSD 3-Clause "New" or "Revised" License

703 stars 4.89k forks source link

Add vulkan-volk #27531

Closed hmaarrfk closed 3 weeks ago

hmaarrfk commented 3 weeks ago

Checklist

[ ] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
[ ] License file is packaged (see here for an example).
[ ] Source is from official source.
[ ] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
[ ] If static libraries are linked in, the license of the static library is packaged.
[ ] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
[ ] Build number is 0.
[ ] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
[ ] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
[ ] When in trouble, please check our knowledge base documentation before pinging a team.

conda-forge-webservices[bot] commented 3 weeks ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/vulkan-volk/meta.yaml) and found some lint.

Here's what I've got...

For recipes/vulkan-volk/meta.yaml:

This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see https://github.com/conda-forge/conda-forge.github.io/issues/2102.

conda-forge-webservices[bot] commented 3 weeks ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vulkan-volk/meta.yaml) and found it was in an excellent condition.

conda-forge-webservices[bot] commented 3 weeks ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/vulkan-volk/meta.yaml) and found some lint.

Here's what I've got...

For recipes/vulkan-volk/meta.yaml:

pin_subpackage should be used instead of pin_compatible for vulkan-volk because it is one of the known outputs of this recipe: ['vulkan-volk'].

conda-forge-webservices[bot] commented 3 weeks ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vulkan-volk/meta.yaml) and found it was in an excellent condition.

hmaarrfk commented 3 weeks ago

@libvulkan-loader @libvulkan-headers I would appreciate your review here, it seems like this is now a dependency of https://github.com/conda-forge/vulkan-tools-feedstock/pull/8

hmaarrfk commented 3 weeks ago

@conda-forge/vulkan-loader @conda-forge/vulkan-headers

hmaarrfk commented 3 weeks ago

The recipe seems fine! Just to understand, what is the reason why this needs to be a static library?

https://github.com/zeux/volk?tab=readme-ov-file#building

This is all i know. I had opened PRs but they seem to include a volk.c inside the volk.h file, so I figured this was likely some super trickery that was being made..... didn't seem safe to deviate too much from upstream.

I had opened PRs https://github.com/zeux/volk/pull/202 https://github.com/zeux/volk/pull/201 but i figured i would use them as intended first, then make recommendations.

hmaarrfk commented 3 weeks ago

Thanks you two, let me know if you want to help maintain downstream by pinging me on the feedstock