conda-forge / staged-recipes

A place to submit conda recipes before they become fully fledged conda-forge feedstocks
https://conda-forge.org
BSD 3-Clause "New" or "Revised" License
711 stars 4.97k forks source link

mvapich #27718

Closed j34ni closed 1 month ago

j34ni commented 1 month ago

Checklist

github-actions[bot] commented 1 month ago

Hi! This is the staged-recipes linter and I found some lint.

It looks like some changes were made outside the recipes/ directory. To ensure everything runs smoothly, please make sure that recipes are only added to the recipes/ directory and no other files are changed.

If these changes are intentional (and you aren't submitting a recipe), please add a maintenance label to the PR.

File-specific lints and/or hints:

github-actions[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mvapich2/meta.yaml) and found it was in an excellent condition.

github-actions[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

github-actions[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mvapich2/meta.yaml) and found it was in an excellent condition.

j34ni commented 1 month ago

@conda-forge/staged-recipes I need some help here: the build is successful locally and on Azure (linux-64 only, for now), the "mpiexec -n 2 ./mpihello" test also passes, but outside the build environment there seems to be an issue withglibcxx and for instance the mpichversion command gives:

mpichversion: /lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by /usr/local/conda/bin/../lib/./././libicuuc.so.75)
github-actions[bot] commented 1 month ago

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

github-actions[bot] commented 1 month ago

Hi! This is the staged-recipes linter and your PR looks excellent! :rocket:

xhochy commented 1 month ago

@conda-forge/staged-recipes I need some help here: the build is successful locally and on Azure (linux-64 only, for now), the "mpiexec -n 2 ./mpihello" test also passes, but outside the build environment there seems to be an issue withglibcxx and for instance the mpichversion command gives:

mpichversion: /lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by /usr/local/conda/bin/../lib/./././libicuuc.so.75)

What does outside the build environment mean for you?

github-actions[bot] commented 1 month ago

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

j34ni commented 1 month ago

@xhochy Hi, I meant that I tried to use directly the mvapich...conda file produced locally, but I must have messed up the dependencies somehow...

j34ni commented 1 month ago

Thanks @minrk, this make the recipe quite clean now

j34ni commented 1 month ago

@minrk Great, thanks

Sent from Outlook for iOShttps://aka.ms/o0ukef


From: Min RK @.> Sent: Tuesday, October 1, 2024 2:08:24 PM To: conda-forge/staged-recipes @.> Cc: Jean Iaquinta @.>; Author @.> Subject: Re: [conda-forge/staged-recipes] mvapich (PR #27718)

@minrk approved this pull request.

— Reply to this email directly, view it on GitHubhttps://github.com/conda-forge/staged-recipes/pull/27718#pullrequestreview-2340009743, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKRWC32RE2FSKC2YFMA76Q3ZZKGDRAVCNFSM6AAAAABPAWW23SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNBQGAYDSNZUGM. You are receiving this because you authored the thread.Message ID: @.***>

j34ni commented 1 month ago

@conda-forge/staged-recipes is there something else to do on my side?

github-actions[bot] commented 1 month ago

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!