Reviewer sub-teams

[CJ-Wright]

It might be nice to have staged-recipes reviewers sub-teams. These sub-teams would feature different domain expertise. For example there could be dedicated R sub-team for reviewing R recipes. This should:

1. Cut down on noise for reviewers (you only get pinged for stuff you know about)
2. Help submitters get help/review from people who have the skills to help/review their recipes
3. Still be able to ping the entire team (if you aren't certain)

Attn: @synapticarbors @conda-forge/staged-recipes @conda-forge/core

[bgruening]

Yes please! See https://github.com/orgs/bioconda/teams

[CJ-Wright]

@bgruening non-bioconda team members can't see the teams :(

[patricksnape]

I like the idea - would definitely make it easier to draft people in if they only had to handle platforms they were familiar with.

[pelson]

Yes please! 😄 I've been keen to do this from day 1 of conda-forge. There is plenty of evidence that supports doing this in terms of bringing in new long-term contributors.... https://www.youtube.com/watch?v=ZSQJYEVcMWM

What I've wanted to do is have a very clear info graphic showing the different teams and their responsibilities/expectations. Any interest in putting that together?

[CJ-Wright]

Who has permissions to do this?

[isuruf]

The core team can add new teams in conda-forge.

[pelson]

TBH, we could do with tidying up the way we do team in Github. Since conda-forge came along, github have added the notion of "groups of teams" which would dramatically simplify the interface that conda-forge admins see when they visit the page with 3000+ teams 😄

As for setting up the sub-teams - what are the suggestions? staged-recipes-r-lang? Any others?

[synapticarbors]

I think it would be helpful to have the following teams:

• python
• r
• java
• nodejs
• some category of compiled languages like c/c++
• perl

I think this is a fairly comprehensive list of the types of packages that I've seen, although I may be missing some.

[CJ-Wright]

Maybe add Julia and some python c/c++ hybrid?

[jakirkham]

I wonder if we can just make a group staged-recipes and add these teams below that group.

Also agree that we should probably move all feedstock teams under a group (maybe feedstocks).

[CJ-Wright]

Would it be possible to get an implementation of this? (even a basic version?)

[igortg]

Hey guys

In the last weeks, I have been jumping into some reviews on my own. Do not have much experience, but could point out some mistakes new people frequently makes (noarch, license issues, recipe yml standards, dependencies).

If you want some help, I would be willing to get into the python reviewers sub-group. Just let me know if there is some process to become an official reviewer.

[rth]

Since conda-forge came along, github have added the notion of "groups of teams" which would dramatically simplify the interface that conda-forge admins see when they visit the page with 3000+ teams

Another, possibly related point is that some third party CI services handle badly orgs with ~4000 repositories. For instance, I'm not part of the core dev group on conda forge, however, when I try to setup CI for some of my own packages

• Appveyor will automatically list all the packages of orgs I belong to including all the conda-packages. On good days it will take a while, but will still work. On bad, I'll hit the API limit while trying to load the list. cf https://github.com/appveyor/ci/issues/2010
  • ReadTheDocs is worse: it will show a paginated view of conda-forge repositories, and it's pretty much not usable https://github.com/rtfd/readthedocs.org/issues/1899

I'm not sure anything can be done about it during this team re-organization, but at some level I find it surprising that I'm offered to setup CI on repos I have no write access on. Isn't there anything that can be done about it on the conda-forge side? I'm not sure - maybe this was discussed somewhere else?

(This will still be an issue for conda-forge admins unfortunately :/ )

[CJ-Wright]

• [x] python @conda-forge/help-python
• [x] r @conda-forge/help-r
• [x] java @conda-forge/help-java
• [x] nodejs @conda-forge/help-nodejs
• [x] c/c++ @conda-forge/help-c-cpp
• [x] perl @conda-forge/help-perl
• [x] Julia @conda-forge/help-julia
• [x] python/c hybrid @conda-forge/help-python-c

[CJ-Wright]

@conda-forge/staged-recipes I've started creating the language reviewer sub-teams The current format is @conda-forge/help-<language> Please see https://github.com/conda-forge/staged-recipes/issues/4729#issuecomment-374941081 for a list of the currently available sub-teams. (let me know if I need to add more).

With that said could everyone who wants to be on sub-teams please post in this issue which sub-teams they want to be on?

I will also PR into the repo a PR template which tells people about the help teams so they know who to talk to.

[mwcraig]

python and python/c for me please.

[djsutherland]

I'd do python, python/c, "some category of compiled languages", and nodejs.

[synapticarbors]

python and python/c

[CJ-Wright]

@synapticarbors do you have permissions to add yourself to the subteams? (this would make my life much simpler)

[mariusvniekerk]

I'd do python, python/c, maybe some java

[synapticarbors]

@CJ-Wright I see a button "request to join", so I'm assuming I don't have the correct level of permissions.

[CJ-Wright]

Ah ok I was afraid of that, I will continue adding people then.

[igortg]

I'd do python

[CJ-Wright]

@bgruening can I add you to the r team?

[jakirkham]

Did we add a team for go?

[CJ-Wright]

I have added a @conda-forge/help-go team. Is anyone interested in helping out with go?

[jakirkham]

^ @sodre 😉

[sodre]

Sign me up 👍

[marcelotrevisani]

Python and C/C++ for me please

[tadeu]

@CJ-Wright, I'm coming late to the thread, but I can help with C/C++ :)

[CJ-Wright]

@tadeu are you a staged-recipes reviewer?

[tadeu]

Not yet but I contribute with recipes/feedstocks and I'm willing to give help to recipes asking for help-c-cpp, since I have some expertise with C/C++ recipes, and saw that there are only 3 helpers in this area for now