search

conda-forge / staged-recipes

A place to submit conda recipes before they become fully fledged conda-forge feedstocks
https://conda-forge.org
BSD 3-Clause "New" or "Revised" License
709 stars 4.95k forks source link

RFC: Adding projects with very long test suites #675

Closed ericdill closed 8 years ago

ericdill commented 8 years ago

So here's a fun one. fabio is a library that abstracts away the various specs for a number of scientific data formats common at synchrotrons and some other facilities. The test suite for this library downloads a bunch of files and makes sure that it can open them. As such, the test suite takes quite a while. On my i7 ssd laptop it took ~10 minutes. Opening this issue to figure out the best way to proceed.

  1. Should I just skip running the test suite?
  2. Run the test suite and clog up CI?
  3. Some other option I haven't thought of?

recipe

dopplershift commented 8 years ago

I thought the idea on tests wasn't to run the package's own tests (because of time, packages shipping with failing tests, etc.) but just a set of tests that tries to ensure the package isn't broken (bad build, bad linking, etc.)

pelson commented 8 years ago

I generally agree with this approach @dopplershift. There is definitely a gray line though, and really it has to be a judgement call on whether there is insufficient confidence in the built package to warrant the cost of running the entire test suite.