Separates core and optional requirements

conda-forge / starlette-feedstock

A conda-smithy repository for starlette.

BSD 3-Clause "New" or "Revised" License

1 stars 8 forks source link

Separates core and optional requirements #47

Closed dgasmith closed 4 years ago

dgasmith commented 4 years ago

This splits the Starlette package into "core" and non-core components so that all of the extra dependancies do not ride along with the package. This is very useful to prevent these unused dependancies.

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'test', 'outputs', 'about', 'extra'].

dgasmith commented 4 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dgasmith commented 4 years ago

Ah, this is incompatible with noarch.

carlodri commented 4 years ago

you could try this workaround: https://github.com/conda/conda-build/issues/3495