starlette-base should have a run_constraint on starlet

conda-forge / starlette-feedstock

A conda-smithy repository for starlette.

BSD 3-Clause "New" or "Revised" License

1 stars 8 forks source link

starlette-base should have a run_constraint on starlet #57

Closed xhochy closed 3 years ago

xhochy commented 3 years ago

[x] I read the conda-forge documentation and could not find the solution for my problem there.

Issue:

We see issues like https://github.com/conda-forge/fastapi-feedstock/issues/43 popping up where an old starlette-base version is installed alongside a new starlette version causing file clobbering and random behaviour which version of starlette is actually installed really at the end.

Thus we should add a repodata patch that add a run_constraint for starlette to starlette-base.

carlodri commented 3 years ago

Thanks for reporting, and sorry for the mess....starlette-base no longer exists, it existed only for versions 0.13.5 and 0.13.6. Packages were then renamed to starlette and starlette-full. How do you suggest we fix this? We could mark those packages as broken so that the legacy naming disappears, and if those specific versions are required we could make a back-release. What do you think?

xhochy commented 3 years ago

I would just patch the repodata.json with the above run_constrained. PR coming from me in the next days.

xhochy commented 3 years ago

Made a PR at https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/106