conda-forge / starlette-feedstock

A conda-smithy repository for starlette.
BSD 3-Clause "New" or "Revised" License
1 stars 8 forks source link

py.typed file is not included in Conda packages of starlette #61

Closed Quogu closed 2 years ago

Quogu commented 3 years ago

Issue: py.typed file is not included in Conda packages of starlette from conda-forge.

This is true for at least https://anaconda.org/conda-forge/starlette/0.16.0/download/noarch/starlette-0.16.0-pyhd8ed1ab_0.tar.bz2 and https://anaconda.org/conda-forge/starlette/0.14.2/download/noarch/starlette-0.14.2-pyhd8ed1ab_0.tar.bz2 - please can this be fixed, and a new build produced for 0.14.2 as well as newer versions? (This version is relevant because it's what fastapi currently uses.)
Environment (conda list): Not applicable
Details about conda and system ( conda info ): Not applicable

carlodri commented 3 years ago

Is this still relevant? Which Python version are you using? I'm asking since it might be due to the fact that we are missing this dependency for python < 3.8:

https://github.com/encode/starlette/blob/2b3f5e6805095049dcea4faea6102b564348073a/setup.py#L42

carlodri commented 2 years ago

@Quogu please reopen if relevant