suitesparse 5.7.2 (redux)

conda-forge / suitesparse-feedstock

A conda-smithy repository for suitesparse.

BSD 3-Clause "New" or "Revised" License

1 stars 16 forks source link

suitesparse 5.7.2 (redux) #64

Closed h-vetinari closed 4 years ago

h-vetinari commented 4 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

This picks up the fixed patches from @minrk in #61, together with the version bump from #63.

Closes #60 Closes #61 Closes #62 Closes #63

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

h-vetinari commented 4 years ago

@conda-forge-admin, please rerender

h-vetinari commented 4 years ago

The two extant patches have been upstreamed by @minrk in DrTimothyAldenDavis/SuiteSparse#7 & DrTimothyAldenDavis/SuiteSparse#8, so I removed them outright.

h-vetinari commented 4 years ago

@conda-forge/suitesparse This is green and should allow to close all open PRs. Next step: windows builds. ;-)

h-vetinari commented 4 years ago

PS. Link to the discussion about the conda-smithy warning regarding license identifiers.

grlee77 commented 4 years ago

Thanks @h-vetinari. Not having the patches should make future automatic updates easier!

h-vetinari commented 4 years ago

@grlee77: Thanks @h-vetinari.

Happy to help. I want to fix the suboptimal cvxopt build (currently building and statically linking suitesparse for windows within that recipe), so it made sense to start here. In turn, this also means that cvxopt already knows how to build suitesparse for windows, so I'm hopeful I can leverage that (somehow) into a windows build here (cf. #51).

Not having the patches should make future automatic updates easier!

All credit for that belongs to @minrk! :)