search

conda-forge / suitesparse-feedstock

A conda-smithy repository for suitesparse.
BSD 3-Clause "New" or "Revised" License
1 stars 16 forks source link

[windows] updated v5.4.0 #65

Closed seanyen closed 4 years ago

seanyen commented 4 years ago

Checklist

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

For recipe:

seanyen commented 4 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

seanyen commented 4 years ago

@conda-forge-admin, please rerender

seanyen commented 4 years ago

@conda-forge/suitesparse This is a version bump and ready for review and merge. Thanks!

jschueller commented 4 years ago

please rebase from master, it's 5.7.2 now

seanyen commented 4 years ago

@jschueller

It looks like the SuiteSparse for Windows build lives for its own on this separate branch since this and it takes the source from this project instead: https://github.com/jlblancoc/suitesparse-metis-for-windows, which attempts to keep CMake recipes for cross-platform compiling and now it is ported to v5.4.0.

I don't think doing a simple rebase of this feedstock can take it to v5.7.2. Or maybe I misread your comments? What's the step I should take?

jschueller commented 4 years ago

oh, right, I did not see that.

seanyen commented 4 years ago

@conda-forge/suitesparse @conda-forge/core This is ready for review and merge. Thanks!

beckermr commented 4 years ago

pls only bump the team and not core on these. We can help if this is not merged for about a week or so.

seanyen commented 4 years ago

@conda-forge-admin, please rerender.

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

seanyen commented 4 years ago

@isuruf Btw, I saw there are some warnings like these:

Do you recommend to add libopenblas to the run requirements? Currently I am only adding blas meta-package as the run dependency.

WARNING (suitesparse,Library\bin\cholmod.dll): Needed DSO Library\bin\openblas.dll found in ['libopenblas']
WARNING (suitesparse,Library\bin\cholmod.dll): .. but ['libopenblas'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
seanyen commented 4 years ago

@isuruf hmm, the CI seems not to like the changes. What should we do for the next step?

isuruf commented 4 years ago

Try deleting %PREFIX%/Library/lib/cmake/ ?

seanyen commented 4 years ago

@isuruf Just wondering, what's the latest doc for how to integrate with blas? Is this one still up-to-dated? https://conda-forge.readthedocs.io/en/latest/blas.html

isuruf commented 4 years ago

It's the one at https://conda-forge.org/docs/maintainer/knowledge_base.html#blas

seanyen commented 4 years ago

I see, so I probably looked at a old site (https://conda-forge.readthedocs.io/) instead of the latest one (https://conda-forge.org/docs/index.html).

isuruf commented 4 years ago

Thanks. I'll see if I can get that old site deleted.

seanyen commented 4 years ago

@conda-forge/suitesparse Friendly ping. I think this is ready for merge. Thanks.

h-vetinari commented 4 years ago

Great to see this happening. I was planning to get around to doing this myself after having built suitesparse for windows within conda-forge/cvxopt-feedstock#42.

I detailed some of that in #51 - I believe (hope?) that metis is not necessary and that we can go to 5.7.2 directly.

seanyen commented 4 years ago

Great to see this happening. I was planning to get around to doing this myself after having built suitesparse for windows within conda-forge/cvxopt-feedstock#42.

Happy to see the progress on this too. For my short-term goal, I just want to have ceres Windows port with suitesparse enabled, so I can do a conda-forge feedstock for https://github.com/cartographer-project/cartographer. And I am happy to see any attempts to get it converged toward to that direction. :)

grlee77 commented 4 years ago

I am inclined to go ahead and merge this soon given that it is now passing CI. That said, I don't have experience with Windows + SuitSparse/METIS and would appreciate any feedback from other maintainers.

h-vetinari commented 4 years ago

@seanyen True, there's no reason not to merge this, any progress can come on top of this PR.

seanyen commented 4 years ago

Thank you all!