Rebuild for metis511 - Githubissues

regro-cf-autotick-bot commented 1 year ago

This PR has been triggered in an effort to update metis511.

Notes and instructions for merging this PR:

Please merge the PR only after the tests have passed.
Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6815257159, please use this URL for debugging.}

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

traversaro commented 1 year ago

Hello everyone, just a small warning on this migration: from METIS 5.1.0 to 5.1.1 the values of the enum moptions_et, including constants such as METIS_OPTION_NUMBERING (see https://github.com/KarypisLab/METIS/issues/71#issuecomment-1697008951) have changed in backward incompatible way. So if this values are hardcoded in the code (as it happens for example for FORTRAN libraries), those values needs to be changed, as otherwise the wrong option is silently used. If instead the constants are used (for example in C/C++ code) the migration should be ok. See https://github.com/conda-forge/mumps-feedstock/blob/c524cb3c71686bee59d9b12df5d9d6ce20782ce4/recipe/mumps_support_only_metis_5_1_1.patch for example patch fixing this for MUMPS. Related issues:

traversaro commented 1 year ago

Hello everyone, just a small warning on this migration: from METIS 5.1.0 to 5.1.1 the values of the enum moptions_et, including constants such as METIS_OPTION_NUMBERING (see KarypisLab/METIS#71 (comment)) have changed in backward incompatible way. So if this values are hardcoded in the code (as it happens for example for FORTRAN libraries), those values needs to be changed, as otherwise the wrong option is silently used. If instead the constants are used (for example in C/C++ code) the migration should be ok. See https://github.com/conda-forge/mumps-feedstock/blob/c524cb3c71686bee59d9b12df5d9d6ce20782ce4/recipe/mumps_support_only_metis_5_1_1.patch for example patch fixing this for MUMPS. Related issues:
* [Large 2000x peformance regression from 5.1 to 5.2 KarypisLab/METIS#71](https://github.com/KarypisLab/METIS/issues/71)

* [Version 5.1.1 breaks downstream software metis-feedstock#35](https://github.com/conda-forge/metis-feedstock/issues/35)

* [metis wrapper broken with metis 5.1.1 and 5.2.1  ralna/spral#133](https://github.com/ralna/spral/issues/133)

At a first glance it seems that the constants are used (see for example https://github.com/DrTimothyAldenDavis/SuiteSparse/blob/8627b9c4423188230e0fa7c46f32a3abb3f77405/CHOLMOD/SuiteSparse_metis/programs/gpmetis.c#L76), so I think it is ok to merge.

traversaro commented 12 months ago

@conda-forge-admin please rerender