conda-forge / sundials-feedstock

A conda-smithy repository for sundials.
BSD 3-Clause "New" or "Revised" License
4 stars 10 forks source link

add fortran compiler #52

Closed utsekaj42 closed 4 years ago

utsekaj42 commented 5 years ago

Checklist

Wasn't sure how to request a new branch (3.1.1).

I assume adding the fortran compiler wouldn't hurt the other branches, but I'm intending this to improve distribution of a package that depends on sundials 3.1.1 with fortran support.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jschueller commented 5 years ago
utsekaj42 commented 5 years ago

Hmm, I need to do some more testing locally. I thought the build I had worked, but on further inspection it seems not have.

I am not entirely sure if there are breaking changes from 3.1.1 to 3.2 but the package, scikits.odes, only supports 3.1.1 .

Outside of the feed-stock, building with

cmake \
-DLAPACK_ENABLE=ON \
 -DSUNDIALS_INDEX_TYPE=int32_t \
-DCMAKE_INSTALL_PREFIX=$CONDA_PREFIX ../sundials-3.1.1/  
make install

is sufficient to then install scikits.odes, but installing the package resulting from 'build-locally.py' doesn't seem to work the same.

bjodah commented 5 years ago

@utsekaj42 have you tried with 3.2.1? Looks like nix uses it: https://github.com/flokli/nixpkgs/commit/7e9e22f4d57816a74a7050a8edc0e85d63427fea

EDIT: besides, looks like sundials-4 support could be near? xref. https://github.com/bmcage/odes/pull/106

jschueller commented 4 years ago

outdated