search

conda-forge / sympy-feedstock

A conda-smithy repository for sympy.
BSD 3-Clause "New" or "Revised" License
3 stars 15 forks source link

Backport https://github.com/sympy/sympy/pull/13276 #9

Closed saraedum closed 6 years ago

saraedum commented 6 years ago

which causes trouble in Sage

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

asmeurer commented 6 years ago

A note on backporting. The backporting here seems fine, since it fixes an issue with an upstream package (assumedly an important one).

But in general, I would be very conservative about backports in conda-forge packages. It moves package maintenance from the library itself, where the developers are, to the package. And it can cause confusion when the behavior of the package doesn't match the behavior of the respective git tag/PyPI release.

saraedum commented 6 years ago

@asmeurer: Thanks for the comment. I think I agree to be a bit conservative about backporting. In this case, the change is minimal, it's a bugfix that I don't think can break any valid usage, and it's already in upstream. So, all in all, I think it's fine to backport this given that sympy does not seem to be releasing very frequently.

If anybody has any reservations about this backport, I do not mind too much to drop this PR.

asmeurer commented 6 years ago

The backport is needed for the upstream Sage package to work, I take it?

I think valid reasons for backport patches are:

And the case is much stronger for packages like SymPy that don't release very often.

asmeurer commented 6 years ago

This shouldn't be needed any more with 1.2.