search

conda-forge / tectonic-feedstock

A conda-smithy repository for tectonic.
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Rebuild for icu72 #60

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

This PR has been triggered in an effort to update icu72.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/4539862140, please use this URL for debugging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pkgw commented 1 year ago

osx-64 failing with a linker error:

Undefined symbols for architecture x86_64:
            "_renameat", referenced from:

It looks like https://github.com/conda-forge/rust-feedstock/issues/73 rearing its head again. In https://github.com/rust-lang/rust/pull/104385, I am seeing some active discussion about raising minimum macOS versions, but it doesn't look like there's been a clear policy decision. But, my understanding is that Rust's CI doesn't necessarily test older macOS versions thoroughly so accidental bumps might slip through.

pkgw commented 1 year ago

Rust 1.68.2 has just gone in, in conda-forge/rust-feedstock#132, and maybe that will just magically fix this issue?

pkgw commented 1 year ago

@conda-forge-admin, please restart ci

update: same issue, unfortunately

pkgw commented 1 year ago

@conda-forge-admin, please restart ci

(one more try just in case ...)

pkgw commented 1 year ago

OK, I was actually not looking closely enough with the Mac error. The issue is in the Rustix crate, which manually implements various IO system calls. It seems that it doesn't have the right checks to sync up its API with the macOS deployment target here. I don't see an easy way to prevent that, and I think it's unlikely that Rustix is going to commit to compatibility for such an old OS version, so I think we have to bump the minimum version here.