Relax typing extensions pin on 2.13.1

conda-forge / tensorflow-feedstock

A conda-smithy repository for tensorflow.

BSD 3-Clause "New" or "Revised" License

91 stars 81 forks source link

Relax typing extensions pin on 2.13.1 #349

Closed hmaarrfk closed 8 months ago

hmaarrfk commented 8 months ago

It seems that tensorflow removed the upper bound with little fanfare https://github.com/tensorflow/tensorflow/commit/19b7519c2ec7b208aa6c1145132c84ebcbd795b0#diff-f526feeafa1000c4773410bdc5417c4022cb2c7b686ae658b629beb541ae9112R101

going to try to build locally to see

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 8 months ago

if we want to relax this, we should do this with a repodatapatch

hmaarrfk commented 8 months ago

As limited proof of function, I want to report that I was able to run an internal test suite with the following:

$ mamba list |  grep -E "tensorflow-base |typing_extensions "
tensorflow-base           2.13.1          cuda118py39h712810b_1    mark.harfouche
typing_extensions         4.8.0              pyha770c72_0    conda-forge

the package from the mark.harfouche channel is a hand edited package that releases the restrictions on typing_extensions imposed by the conda forge package (downloaded the conda file, then edited the info.json manually and let Ubuntu's Archive Manager repackage two nested archive).