search

conda-forge / tensorflow-feedstock

A conda-smithy repository for tensorflow.
BSD 3-Clause "New" or "Revised" License
91 stars 81 forks source link

tf 2.16, py 3.12, various migrations #385

Closed h-vetinari closed 1 month ago

h-vetinari commented 2 months ago

Based on #379, now that we have the infrastructure from #373.

Check here for updated requirements.

Closes #388 Closes #387 Closes #384 Closes #383 Closes #379 Closes #375 Closes #374 Closes #372 Closes #371

+ python 3.12, protobuf 4.25.3, snappy 1.2

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 2 months ago

@hmaarrfk @xhochy @njzjz How did we deal with abseil vs. bazel in the past?

ERROR: $SRC_DIR/tensorflow/python/saved_model/BUILD:897:27: no such target '@com_google_absl//absl/strings:string_view': target 'string_view' not declared in package 'absl/strings' defined by $BUILD_PREFIX/share/bazel/00a0ad09a9f2088f9cf5d7c9c9667330/external/com_google_absl/absl/strings/BUILD.bazel (Tip: use `query "@com_google_absl//absl/strings:*"` to see all the targets in that package) and referenced by '//tensorflow/python/saved_model:pywrap_saved_model.so'
njzjz commented 2 months ago

@hmaarrfk @xhochy @njzjz

How did we deal with abseil vs. bazel in the past?


ERROR: $SRC_DIR/tensorflow/python/saved_model/BUILD:897:27: no such target '@com_google_absl//absl/strings:string_view': target 'string_view' not declared in package 'absl/strings' defined by $BUILD_PREFIX/share/bazel/00a0ad09a9f2088f9cf5d7c9c9667330/external/com_google_absl/absl/strings/BUILD.bazel (Tip: use `query "@com_google_absl//absl/strings:*"` to see all the targets in that package) and referenced by '//tensorflow/python/saved_model:pywrap_saved_model.so'

Need to patch https://github.com/tensorflow/tensorflow/blob/master/third_party/absl/system.absl.strings.BUILD. string_view is given by https://github.com/abseil/abseil-cpp/blob/master/absl/strings/BUILD.bazel.

h-vetinari commented 2 months ago

Thanks! How did we not hit this in previous versions yet? 🤔

Need to patch https://github.com/tensorflow/tensorflow/blob/master/third_party/absl/system.absl.strings.BUILD. string_view is given by https://github.com/abseil/abseil-cpp/blob/master/absl/strings/BUILD.bazel.

Feel free to commit into this PR if you want/can!

hmaarrfk commented 2 months ago

Thanks! How did we not hit this in previous versions yet? 🤔

we kinda did and I was hacking around it in my attempts. I gave up and we are where we are today!

h-vetinari commented 2 months ago

Alright, finally we're compiling something here.

h-vetinari commented 2 months ago

Back to some abseil issues... Non-CUDA:

slow_operation_alarm.cc:(.text._ZN3xla18SlowOperationAlarm9AlarmLoopEv+0x21c): undefined reference to `absl::lts_20240116::synchronization_internal::KernelTimeout::KernelTimeout(absl::lts_20240116::Time)'
collect2: error: ld returned 1 exit status
[11,831 / 12,416] checking cached actions

We already discussed this one in #372 a bit, I ended up raising https://github.com/abseil/abseil-cpp/issues/1630, which hasn't progressed since then.

CUDA:

external/local_xla/xla/service/gpu/ir_emitter_triton.cc: In function 'absl::lts_20240116::StatusOr<xla::gpu::TritonWrapperResult> xla::gpu::TritonWrapper(const TritonFusionAnalysis&, absl::lts_20240116::string_view, const xla::HloComputation*, absl::lts_20240116::string_view, const stream_executor::CudaComputeCapability&, const stream_executor::DeviceDescription&, const TritonGemmConfig&, llvm::Module*, TritonIrEmitter, mlir::MLIRContext&)':
external/local_xla/xla/service/gpu/ir_emitter_triton.cc:2222:29: error: conversion from '<brace-enclosed initializer list>' to 'absl::lts_20240116::StatusOr<xla::gpu::TritonWrapperResult>' is ambiguous
 2222 |   return {{shared_mem_bytes}};
      |                             ^
In file included from external/local_xla/xla/status.h:21,
                 from external/local_xla/xla/statusor.h:18:
$PREFIX/include/absl/status/statusor.h:459:3: note: candidate: 'absl::lts_20240116::StatusOr<T>::StatusOr(U&&) [with U = xla::gpu::TritonWrapperResult; typename std::enable_if<absl::lts_20240116::conjunction<absl::lts_20240116::disjunction<std::is_same<T, typename absl::lts_20240116::remove_cvref<U&&>::type>, absl::lts_20240116::negation<absl::lts_20240116::disjunction<std::is_same<absl::lts_20240116::StatusOr<T>, typename absl::lts_20240116::remove_cvref<U&&>::type>, std::is_same<absl::lts_20240116::Status, typename absl::lts_20240116::remove_cvref<U&&>::type>, std::is_same<std::in_place_t, typename absl::lts_20240116::remove_cvref<U&&>::type>, absl::lts_20240116::internal_statusor::IsDirectInitializationAmbiguous<T, U&&> > > >, std::is_constructible<T, U&&>, std::is_convertible<U&&, T>, absl::lts_20240116::disjunction<std::is_same<typename absl::lts_20240116::remove_cvref<U>::type, T>, absl::lts_20240116::conjunction<absl::lts_20240116::negation<std::is_convertible<U&&, absl::lts_20240116::Status> >, absl::lts_20240116::negation<absl::lts_20240116::internal_statusor::HasConversionOperatorToStatusOr<T, U&&, void> > > > >::value, int>::type <anonymous> = 0; T = xla::gpu::TritonWrapperResult]'
  459 |   StatusOr(U&& u)  // NOLINT
      |   ^~~~~~~~
$PREFIX/include/absl/status/statusor.h:365:3: note: candidate: 'absl::lts_20240116::StatusOr<T>::StatusOr(U&&) [with U = absl::lts_20240116::Status; typename std::enable_if<absl::lts_20240116::conjunction<std::is_convertible<U&&, absl::lts_20240116::Status>, std::is_constructible<absl::lts_20240116::Status, U&&>, absl::lts_20240116::negation<std::is_same<typename std::decay<_Func>::type, absl::lts_20240116::StatusOr<T> > >, absl::lts_20240116::negation<std::is_same<typename std::decay<_Func>::type, Key> >, absl::lts_20240116::negation<std::is_same<typename std::decay<_Func>::type, std::in_place_t> >, absl::lts_20240116::negation<absl::lts_20240116::internal_statusor::HasConversionOperatorToStatusOr<T, U&&, void> > >::value, int>::type <anonymous> = 0; T = xla::gpu::TritonWrapperResult]'
  365 |   StatusOr(U&& v) : Base(std::forward<U>(v)) {}
      |   ^~~~~~~~
[18,587 / 25,213] checking cached actions
h-vetinari commented 2 months ago

For the CUDA error, I see that the failing function wants to return a absl::StatusOr<TritonWrapperResult>, where the inner type (in case of success) is just a simple struct:

struct TritonWrapperResult {
  int64_t shmem_bytes;
};

Let's try if a patch that makes the type more explicit can help...

hmaarrfk commented 2 months ago

Great work!

h-vetinari commented 2 months ago

I think we're getting closer now; the compilation passed, there were just the missing ml_dtypes headers when testing libtensorflow_cc. @hmaarrfk or @xhochy could you maybe do a test build for a single python version on osx, to see if we're running into other problems there?

Long term I'd like to switch this to megabuilds like pytorch, and maybe even cross-compile osx from linux. But for now I'm mostly concentrated on unblocking the new version plus various migrations (tf is the largest remaining blocker for the 3.12 migration).

h-vetinari commented 2 months ago

Turning into home stretch here...

+ pip check
tensorflow 2.16.1 has requirement tensorboard<2.17,>=2.16, but you have tensorboard 2.15.2.
h-vetinari commented 2 months ago

OK, this is passing now on linux, could I please have some review @conda-forge/tensorflow, and perhaps who can help build the osx variants?

hmaarrfk commented 2 months ago

I don't really have a macbook. Maybe i should make a go-fund me page.... lol

hmaarrfk commented 2 months ago

As silly as it is, lets see: https://gofund.me/87eac20a

ngam commented 2 months ago

I can try to build soon; the need here is to 1) see if it works fine, and 2) build the matrix, correct?

As silly as it is, lets see: https://gofund.me/87eac20a

This came up in my feed the other day... https://thenewstack.io/open-source-is-at-a-crossroads/

h-vetinari commented 2 months ago

the need here is to 1) see if it works fine, and 2) build the matrix, correct?

yes! 🙏

1) is hopefully not a problem (🤞), assuming there are no relevant differences between linux/osx.

This came up in my feed the other day... https://thenewstack.io/open-source-is-at-a-crossroads/

Don't we know it 😑

ngam commented 2 months ago 
[6,827 / 12,019] [Sched] Compiling xla/service/shape_inference.cc; 14s ... (10 actions, 2 running)

ERROR: /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/_build_env/share/bazel/c73c2fc5f5d1ce3a29a4186bc4d6fdc4/external/local_xla/xla/translate/mhlo_to_hlo/BUILD:70:11: Compiling xla/translate/mhlo_to_hlo/mlir_hlo_to_hlo.cc failed: (Exit 1): cc_wrapper.sh failed: error executing command (from target @local_xla//xla/translate/mhlo_to_hlo:mlir_hlo_to_hlo) 

...

...

# Configuration: f137aae02689a4c574fdc81b7c819591c67fe5ef712a149c821bc1bb9d8282ed
# Execution platform: @local_execution_config_platform//:platform
external/local_xla/xla/translate/mhlo_to_hlo/mlir_hlo_to_hlo.cc:176:35: error: non-constant-expression cannot be narrowed from type 'uint64_t' (aka 'unsigned long long') to 'unsigned char' in initializer list [-Wc++11-narrowing]
        array.data()[i] = xla::u4{values[i].getZExtValue()};
                                  ^~~~~~~~~~~~~~~~~~~~~~~~
external/local_xla/xla/translate/mhlo_to_hlo/mlir_hlo_to_hlo.cc:176:35: note: insert an explicit cast to silence this issue
        array.data()[i] = xla::u4{values[i].getZExtValue()};
                                  ^~~~~~~~~~~~~~~~~~~~~~~~
                                  static_cast<unsigned char>( )
1 error generated.

Edit: this is building osx_arm64_python3.11.____cpython on an osx-arm machine by simply ./build-locall.py`

ngam commented 2 months ago

I will try to rebuild inside a rosetta osx-64 env soon

h-vetinari commented 2 months ago

Thanks a lot. I don't get why we're failing on a warning, are we using -Werror somewhere? We could also patch that one particular place, but that could be a sisyphean exercise until we catch everything.

Looking at the linux logs, I see:

INFO: Found applicable config definition build:linux in file /home/conda/feedstock_root/build_artifacts/tensorflow-split_1715716812294/work/.bazelrc: --host_copt=-w --copt=-Wno-all --copt=-Wno-extra --copt=-Wno-deprecated --copt=-Wno-deprecated-declarations --copt=-Wno-ignored-attributes --copt=-Wno-array-bounds --copt=-Wunused-result --copt=-Werror=unused-result --copt=-Wswitch --copt=-Werror=switch --copt=-Wno-error=unused-but-set-variable --cxxopt=-std=c++17 --host_cxxopt=-std=c++17 --config=dynamic_kernels --experimental_guard_against_concurrent_changes

which seems to come from here; However, macos should have disabled all warnings, so I really don't know where this is picked up.

Having checked the feedstock first, I found an old comment of yours about what nvidia's TF build (IIUC) does:

# This is the flags that Google use internally with clang.
# Adding them help make the compilation error more readable even if g++ doesn't do exactly as clang.
# Google use -Werror too. But we can't use it as the error from g++ isn't exactly the same and will trigger useless compilation error.
export CC_OPT_FLAGS="$CC_OPT_FLAGS -Wno-address-of-packed-member -Wno-defaulted-function-deleted -Wno-enum-compare-switch -Wno-expansion-to-defined -Wno-ignored-attributes -Wno-ignored-qualifiers -Wno-inconsistent-missing-override -Wno-int-in-bool-context -Wno-misleading-indentation -Wno-potentially-evaluated-expression -Wno-psabi -Wno-range-loop-analysis -Wno-return-std-move -Wno-sizeof-pointer-div -Wno-sizeof-array-div -Wno-string-concatenation -Wno-tautological-constant-compare -Wno-tautological-type-limit-compare -Wno-tautological-undefined-compare -Wno-tautological-unsigned-zero-compare -Wno-tautological-unsigned-enum-zero-compare -Wno-undefined-func-template -Wno-unused-lambda-capture -Wno-unused-local-typedef -Wno-void-pointer-to-int-cast -Wno-uninitialized-const-reference -Wno-compound-token-split -Wno-ambiguous-member-template -Wno-char-subscripts -Wno-error=deprecated-declarations -Wno-extern-c-compat -Wno-gnu-alignof-expression -Wno-gnu-variable-sized-type-not-at-end -Wno-implicit-int-float-conversion -Wno-invalid-source-encoding -Wno-mismatched-tags -Wno-pointer-sign -Wno-private-header -Wno-sign-compare -Wno-signed-unsigned-wchar -Wno-strict-overflow -Wno-trigraphs -Wno-unknown-pragmas -Wno-unused-const-variable -Wno-unused-function -Wno-unused-private-field -Wno-user-defined-warnings -Wvla -Wno-reserved-user-defined-literal -Wno-return-type-c-linkage -Wno-self-assign-overloaded -Woverloaded-virtual -Wnon-virtual-dtor -Wno-deprecated -Wno-invalid-offsetof -Wimplicit-fallthrough -Wno-final-dtor-non-final-class -Wno-c++20-designator -Wno-register -Wno-dynamic-exception-spec"

In particular, it doesn't contain -Wc++11-narrowing. But I don't think this is applicable to us anyway, before we find out where the warnings are being set.

Could you check your logs for something like Found applicable config definition build:macos and post the result?

ngam commented 2 months ago

Confirmed the same exact fail with osx-64 env, so this is robust.

See below for the config (also btw, feel free to edit these comments to make them readable; I don't know what people prefer)

INFO: Reading rc options for 'build' from /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/work/.bazelrc:
  'build' options: --config=macos_arm64 --crosstool_top=//custom_toolchain:toolchain --logging=6 --verbose_failures --define=PREFIX=/Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla --define=PROTOBUF_INCLUDE_PATH=/Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include --config=noaws --cpu=darwin_arm64 --local_cpu_resources=2
INFO: Found applicable config definition build:short_logs in file /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/work/.bazelrc: --output_filter=DONT_MATCH_ANYTHING
INFO: Found applicable config definition build:v2 in file /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/work/.bazelrc: --define=tf_api_version=2 --action_env=TF2_BEHAVIOR=1
INFO: Found applicable config definition build:macos_arm64 in file /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/work/.bazelrc: --cpu=darwin_arm64 --macos_minimum_os=11.0
INFO: Found applicable config definition build:noaws in file /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/work/.bazelrc: --define=no_aws_support=true
INFO: Found applicable config definition build:macos in file /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/work/.bazelrc: --apple_platform_type=macos --copt=-DGRPC_BAZEL_BUILD --features=archive_param_file --copt=-w --cxxopt=-std=c++17 --host_cxxopt=-std=c++17 --config=no_tfrt
INFO: Found applicable config definition build:no_tfrt in file /Users/ngam/tensorflow-feedstock/miniforge3/conda-bld/tensorflow-split_1715896467905/work/.bazelrc: --deleted_packages=tensorflow/compiler/mlir/tfrt,tensorflow/compiler/mlir/tfrt/benchmarks,tensorflow/compiler/mlir/tfrt/ir,tensorflow/compiler/mlir/tfrt/ir/mlrt,tensorflow/compiler/mlir/tfrt/jit/python_binding,tensorflow/compiler/mlir/tfrt/jit/transforms,tensorflow/compiler/mlir/tfrt/python_tests,tensorflow/compiler/mlir/tfrt/tests,tensorflow/compiler/mlir/tfrt/tests/ifrt,tensorflow/compiler/mlir/tfrt/tests/mlrt,tensorflow/compiler/mlir/tfrt/tests/ir,tensorflow/compiler/mlir/tfrt/tests/analysis,tensorflow/compiler/mlir/tfrt/tests/jit,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_tfrt,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_jitrt,tensorflow/compiler/mlir/tfrt/tests/tf_to_corert,tensorflow/compiler/mlir/tfrt/tests/tf_to_tfrt_data,tensorflow/compiler/mlir/tfrt/tests/saved_model,tensorflow/compiler/mlir/tfrt/transforms/lhlo_gpu_to_tfrt_gpu,tensorflow/compiler/mlir/tfrt/transforms/mlrt,tensorflow/core/runtime_fallback,tensorflow/core/runtime_fallback/conversion,tensorflow/core/runtime_fallback/kernel,tensorflow/core/runtime_fallback/opdefs,tensorflow/core/runtime_fallback/runtime,tensorflow/core/runtime_fallback/util,tensorflow/core/runtime_fallback/test,tensorflow/core/runtime_fallback/test/gpu,tensorflow/core/runtime_fallback/test/saved_model,tensorflow/core/runtime_fallback/test/testdata,tensorflow/core/tfrt/stubs,tensorflow/core/tfrt/tfrt_session,tensorflow/core/tfrt/mlrt,tensorflow/core/tfrt/mlrt/attribute,tensorflow/core/tfrt/mlrt/kernel,tensorflow/core/tfrt/mlrt/bytecode,tensorflow/core/tfrt/mlrt/interpreter,tensorflow/compiler/mlir/tfrt/translate/mlrt,tensorflow/compiler/mlir/tfrt/translate/mlrt/testdata,tensorflow/core/tfrt/gpu,tensorflow/core/tfrt/run_handler_thread_pool,tensorflow/core/tfrt/runtime,tensorflow/core/tfrt/saved_model,tensorflow/core/tfrt/graph_executor,tensorflow/core/tfrt/saved_model/tests,tensorflow/core/tfrt/tpu,tensorflow/core/tfrt/utils,tensorflow/core/tfrt/utils/debug,tensorflow/core/tfrt/saved_model/python,tensorflow/core/tfrt/graph_executor/python,tensorflow/core/tfrt/saved_model/utils
ngam commented 2 months ago

The specific code in question was added in https://github.com/openxla/xla/commit/b69a2d95d5df7e01142b356ec478f26d9a623d1a. Not sure if our previous build had this commit ...

h-vetinari commented 2 months ago

What I don't understand is how we can fail on a warning without turning warnings into errors. The config above clearly contains --copt=-w, which is documented to mean "Suppress all warnings", IOW the antithesis of -Werror.

h-vetinari commented 2 months ago

Ah... The joy of vendored packages overriding the defaults and doing their own thing

h-vetinari commented 2 months ago

Ah... The joy of vendored packages overriding the defaults and doing their own thing

Argh, that's a red herring as that file isn't present in 2.16.1...

h-vetinari commented 2 months ago

Could you post the entire log in a gist somewhere?

xhochy commented 2 months ago

See this https://gist.github.com/xhochy/4d73dab51eff5504adfd0698430defc2 for the full compiler line. I don't understand why this warning errors.

h-vetinari commented 2 months ago

That's not so huge that it needs to be in a gist IMO 😅 (though I cleaned up the paths a bit)

[8,602 / 12,407] Compiling xla/mlir_hlo/mhlo/IR/hlo_ops.cc; 60s local ... (8 actions running)
ERROR: $BUILD_PREFIX/share/bazel/d3123197d06fbdfa24ce2d105b5282de/external/local_xla/xla/translate/mhlo_to_hlo/BUILD:70:11: Compiling xla/translate/mhlo_to_hlo/mlir_hlo_to_hlo.cc failed: (Exit 1): cc_wrapper.sh failed: error executing command (from target @local_xla//xla/translate/mhlo_to_hlo:mlir_hlo_to_hlo)
  (cd $BUILD_PREFIX/share/bazel/d3123197d06fbdfa24ce2d105b5282de/execroot/org_tensorflow && \
  exec env - \
    PATH=$SRC_DIR:$BUILD_PREFIX/bin:$PREFIX/bin:/Users/uwe/Development/conda-forge/tensorflow-feedstock/miniforge3/condabin:$BUILD_PREFIX/bin:$PREFIX/bin:/Users/uwe/Development/conda-forge/tensorflow-feedstock/miniforge3/bin:/Users/uwe/mambaforge/condabin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/opt/X11/bin:/Library/Apple/usr/bin:/usr/local/share/dotnet:~/.dotnet/tools:/Users/uwe/.local/bin:/Users/uwe/.pixi/bin \
    PWD=/proc/self/cwd \
    PYTHON_BIN_PATH=$PREFIX/bin/python \
    PYTHON_LIB_PATH=$PREFIX/lib/python3.11/site-packages \
    TF2_BEHAVIOR=1 \
    TF_SYSTEM_LIBS=astor_archive,astunparse_archive,boringssl,com_github_googlecloudplatform_google_cloud_cpp,com_github_grpc_grpc,com_google_absl,com_google_protobuf,curl,cython,dill_archive,flatbuffers,gast_archive,gif,icu,libjpeg_turbo,org_sqlite,png,pybind11,snappy,zlib \
  custom_toolchain/cc_wrapper.sh -MD -MF bazel-out/darwin-opt/bin/external/local_xla/xla/translate/mhlo_to_hlo/_objs/mlir_hlo_to_hlo/mlir_hlo_to_hlo.pic.d '-frandom-seed=bazel-out/darwin-opt/bin/external/local_xla/xla/translate/mhlo_to_hlo/_objs/mlir_hlo_to_hlo/mlir_hlo_to_hlo.pic.o' -fPIC '-DEIGEN_MAX_ALIGN_BYTES=64' -DEIGEN_ALLOW_UNALIGNED_SCALARS '-DEIGEN_USE_AVX512_GEMM_KERNELS=0' -DTF_USE_SNAPPY '-DLLVM_ON_UNIX=1' '-DHAVE_BACKTRACE=1' '-DBACKTRACE_HEADER=<execinfo.h>' '-DLTDL_SHLIB_EXT=".so"' '-DLLVM_PLUGIN_EXT=".so"' '-DLLVM_ENABLE_THREADS=1' '-DHAVE_DEREGISTER_FRAME=1' '-DHAVE_LIBPTHREAD=1' '-DHAVE_PTHREAD_GETNAME_NP=1' '-DHAVE_PTHREAD_H=1' '-DHAVE_PTHREAD_SETNAME_NP=1' '-DHAVE_REGISTER_FRAME=1' '-DHAVE_SETENV_R=1' '-DHAVE_STRERROR_R=1' '-DHAVE_SYSEXITS_H=1' '-DHAVE_UNISTD_H=1' '-DHAVE_MACH_MACH_H=1' '-DHAVE_MALLOC_MALLOC_H=1' '-DHAVE_MALLOC_ZONE_STATISTICS=1' '-DHAVE_PROC_PID_RUSAGE=1' '-DHAVE_UNW_ADD_DYNAMIC_FDE=1' '-DLLVM_NATIVE_ARCH="X86"' '-DLLVM_NATIVE_ASMPARSER=LLVMInitializeX86AsmParser' '-DLLVM_NATIVE_ASMPRINTER=LLVMInitializeX86AsmPrinter' '-DLLVM_NATIVE_DISASSEMBLER=LLVMInitializeX86Disassembler' '-DLLVM_NATIVE_TARGET=LLVMInitializeX86Target' '-DLLVM_NATIVE_TARGETINFO=LLVMInitializeX86TargetInfo' '-DLLVM_NATIVE_TARGETMC=LLVMInitializeX86TargetMC' '-DLLVM_NATIVE_TARGETMCA=LLVMInitializeX86TargetMCA' '-DLLVM_HOST_TRIPLE="x86_64-unknown-darwin"' '-DLLVM_DEFAULT_TARGET_TRIPLE="x86_64-unknown-darwin"' '-DLLVM_VERSION_MAJOR=19' '-DLLVM_VERSION_MINOR=0' '-DLLVM_VERSION_PATCH=0' '-DLLVM_VERSION_STRING="19.0.0git"' -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS '-DBLAKE3_USE_NEON=0' -DBLAKE3_NO_AVX2 -DBLAKE3_NO_AVX512 -DBLAKE3_NO_SSE2 -DBLAKE3_NO_SSE41 '-DBAZEL_CURRENT_REPOSITORY="local_xla"' -iquote external/local_xla -iquote bazel-out/darwin-opt/bin/external/local_xla -iquote external/com_google_absl -iquote bazel-out/darwin-opt/bin/external/com_google_absl -iquote external/eigen_archive -iquote bazel-out/darwin-opt/bin/external/eigen_archive -iquote external/ml_dtypes -iquote bazel-out/darwin-opt/bin/external/ml_dtypes -iquote external/local_tsl -iquote bazel-out/darwin-opt/bin/external/local_tsl -iquote external/nsync -iquote bazel-out/darwin-opt/bin/external/nsync -iquote external/double_conversion -iquote bazel-out/darwin-opt/bin/external/double_conversion -iquote external/com_google_protobuf -iquote bazel-out/darwin-opt/bin/external/com_google_protobuf -iquote external/snappy -iquote bazel-out/darwin-opt/bin/external/snappy -iquote external/com_googlesource_code_re2 -iquote bazel-out/darwin-opt/bin/external/com_googlesource_code_re2 -iquote external/llvm-project -iquote bazel-out/darwin-opt/bin/external/llvm-project -iquote external/stablehlo -iquote bazel-out/darwin-opt/bin/external/stablehlo -iquote external/farmhash_archive -iquote bazel-out/darwin-opt/bin/external/farmhash_archive -Ibazel-out/darwin-opt/bin/external/ml_dtypes/_virtual_includes/int4 -Ibazel-out/darwin-opt/bin/external/ml_dtypes/_virtual_includes/float8 -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mlir_hlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/canonicalize_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/convert_op_folder -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_attrs_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_common -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_pattern_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_typedefs_inc_gen -Ibazel-out/darwin-opt/bin/external/llvm-project/mlir/_virtual_includes/ArithCanonicalizationIncGen -Ibazel-out/darwin-opt/bin/external/llvm-project/mlir/_virtual_includes/AsmParserTokenKinds -Ibazel-out/darwin-opt/bin/external/llvm-project/mlir/_virtual_includes/MLIRShapeCanonicalizationIncGen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/base -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/base_attr_interfaces_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/broadcast_utils -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_ops -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_attrs_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_type_inference -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_assembly_format -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_ops_structs_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_structured_interface -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_structured_interface_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_attrdefs_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_dialect_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_ops -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_passes -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/chlo_legalize_to_hlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/chlo_legalize_to_hlo_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_chlo_to_hlo_op -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_legalize_to_stablehlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_stablehlo_to_hlo_op -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_ops -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_attrs_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_types_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/legalize_to_linalg_utils -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_mhlo_to_scalar_op -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/legalize_to_standard_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lower_complex_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_hlo_to_lhlo_op -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_pass_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_rng_utils -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_scatter_gather_utils -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/shape_component_analysis -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/stablehlo_legalize_to_hlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/type_conversion -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/unfuse_batch_norm -isystem external/eigen_archive -isystem bazel-out/darwin-opt/bin/external/eigen_archive -isystem external/eigen_archive/mkl_include -isystem bazel-out/darwin-opt/bin/external/eigen_archive/mkl_include -isystem external/ml_dtypes -isystem bazel-out/darwin-opt/bin/external/ml_dtypes -isystem external/ml_dtypes/ml_dtypes -isystem bazel-out/darwin-opt/bin/external/ml_dtypes/ml_dtypes -isystem external/nsync/public -isystem bazel-out/darwin-opt/bin/external/nsync/public -isystem external/llvm-project/llvm/include -isystem bazel-out/darwin-opt/bin/external/llvm-project/llvm/include -isystem external/llvm-project/mlir/include -isystem bazel-out/darwin-opt/bin/external/llvm-project/mlir/include -isystem external/farmhash_archive/src -isystem bazel-out/darwin-opt/bin/external/farmhash_archive/src -isystem $PREFIX/include '-march=core2' '-mtune=haswell' -mssse3 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -isystem $PREFIX/include '-fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/tensorflow-split-2.16.1' '-fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix' '-D_FORTIFY_SOURCE=2' -isystem $PREFIX/include '-mmacosx-version-min=10.13' '-mmacosx-version-min=10.13' '-march=core2' '-mtune=haswell' -mssse3 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe '-stdlib=libc++' -fvisibility-inlines-hidden '-fmessage-length=0' -isystem $PREFIX/include '-fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/tensorflow-split-2.16.1' '-fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix' '-D_FORTIFY_SOURCE=2' -isystem $PREFIX/include '-mmacosx-version-min=10.13' '-mmacosx-version-min=10.13' -DGRPC_BAZEL_BUILD -w '-std=c++17' -c external/local_xla/xla/translate/mhlo_to_hlo/mlir_hlo_to_hlo.cc -o bazel-out/darwin-opt/bin/external/local_xla/xla/translate/mhlo_to_hlo/_objs/mlir_hlo_to_hlo/mlir_hlo_to_hlo.pic.o)
# Configuration: cdfb1a5ce32106f8114fc8cac20607fc0b5c61791048b4e8864dad4b71b3e20a
# Execution platform: @local_execution_config_platform//:platform
external/local_xla/xla/translate/mhlo_to_hlo/mlir_hlo_to_hlo.cc:176:35: error: non-constant-expression cannot be narrowed from type 'uint64_t' (aka 'unsigned long long') to 'unsigned char' in initializer list [-Wc++11-narrowing]
        array.data()[i] = xla::u4{values[i].getZExtValue()};
                                  ^~~~~~~~~~~~~~~~~~~~~~~~
external/local_xla/xla/translate/mhlo_to_hlo/mlir_hlo_to_hlo.cc:176:35: note: insert an explicit cast to silence this issue
        array.data()[i] = xla::u4{values[i].getZExtValue()};
                                  ^~~~~~~~~~~~~~~~~~~~~~~~
                                  static_cast<unsigned char>( )
1 error generated.
CONDA_BUILD_SYSROOT=/opt/MacOSX10.13.sdk x86_64-apple-darwin13.4.0-clang -MD -MF bazel-out/darwin-opt/bin/external/local_xla/xla/translate/mhlo_to_hlo/_objs/mlir_hlo_to_hlo/mlir_hlo_to_hlo.pic.d -frandom-seed=bazel-out/darwin-opt/bin/external/local_xla/xla/translate/mhlo_to_hlo/_objs/mlir_hlo_to_hlo/mlir_hlo_to_hlo.pic.o -fPIC -DEIGEN_MAX_ALIGN_BYTES=64 -DEIGEN_ALLOW_UNALIGNED_SCALARS -DEIGEN_USE_AVX512_GEMM_KERNELS=0 -DTF_USE_SNAPPY -DLLVM_ON_UNIX=1 -DHAVE_BACKTRACE=1 -DBACKTRACE_HEADER=<execinfo.h> -DLTDL_SHLIB_EXT=".so" -DLLVM_PLUGIN_EXT=".so" -DLLVM_ENABLE_THREADS=1 -DHAVE_DEREGISTER_FRAME=1 -DHAVE_LIBPTHREAD=1 -DHAVE_PTHREAD_GETNAME_NP=1 -DHAVE_PTHREAD_H=1 -DHAVE_PTHREAD_SETNAME_NP=1 -DHAVE_REGISTER_FRAME=1 -DHAVE_SETENV_R=1 -DHAVE_STRERROR_R=1 -DHAVE_SYSEXITS_H=1 -DHAVE_UNISTD_H=1 -DHAVE_MACH_MACH_H=1 -DHAVE_MALLOC_MALLOC_H=1 -DHAVE_MALLOC_ZONE_STATISTICS=1 -DHAVE_PROC_PID_RUSAGE=1 -DHAVE_UNW_ADD_DYNAMIC_FDE=1 -DLLVM_NATIVE_ARCH="X86" -DLLVM_NATIVE_ASMPARSER=LLVMInitializeX86AsmParser -DLLVM_NATIVE_ASMPRINTER=LLVMInitializeX86AsmPrinter -DLLVM_NATIVE_DISASSEMBLER=LLVMInitializeX86Disassembler -DLLVM_NATIVE_TARGET=LLVMInitializeX86Target -DLLVM_NATIVE_TARGETINFO=LLVMInitializeX86TargetInfo -DLLVM_NATIVE_TARGETMC=LLVMInitializeX86TargetMC -DLLVM_NATIVE_TARGETMCA=LLVMInitializeX86TargetMCA -DLLVM_HOST_TRIPLE="x86_64-unknown-darwin" -DLLVM_DEFAULT_TARGET_TRIPLE="x86_64-unknown-darwin" -DLLVM_VERSION_MAJOR=19 -DLLVM_VERSION_MINOR=0 -DLLVM_VERSION_PATCH=0 -DLLVM_VERSION_STRING="19.0.0git" -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DBLAKE3_USE_NEON=0 -DBLAKE3_NO_AVX2 -DBLAKE3_NO_AVX512 -DBLAKE3_NO_SSE2 -DBLAKE3_NO_SSE41 -DBAZEL_CURRENT_REPOSITORY="local_xla" -iquote external/local_xla -iquote bazel-out/darwin-opt/bin/external/local_xla -iquote external/com_google_absl -iquote bazel-out/darwin-opt/bin/external/com_google_absl -iquote external/eigen_archive -iquote bazel-out/darwin-opt/bin/external/eigen_archive -iquote external/ml_dtypes -iquote bazel-out/darwin-opt/bin/external/ml_dtypes -iquote external/local_tsl -iquote bazel-out/darwin-opt/bin/external/local_tsl -iquote external/nsync -iquote bazel-out/darwin-opt/bin/external/nsync -iquote external/double_conversion -iquote bazel-out/darwin-opt/bin/external/double_conversion -iquote external/com_google_protobuf -iquote bazel-out/darwin-opt/bin/external/com_google_protobuf -iquote external/snappy -iquote bazel-out/darwin-opt/bin/external/snappy -iquote external/com_googlesource_code_re2 -iquote bazel-out/darwin-opt/bin/external/com_googlesource_code_re2 -iquote external/llvm-project -iquote bazel-out/darwin-opt/bin/external/llvm-project -iquote external/stablehlo -iquote bazel-out/darwin-opt/bin/external/stablehlo -iquote external/farmhash_archive -iquote bazel-out/darwin-opt/bin/external/farmhash_archive -Ibazel-out/darwin-opt/bin/external/ml_dtypes/_virtual_includes/int4 -Ibazel-out/darwin-opt/bin/external/ml_dtypes/_virtual_includes/float8 -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mlir_hlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/canonicalize_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/convert_op_folder -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_attrs_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_common -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_pattern_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_ops_typedefs_inc_gen -Ibazel-out/darwin-opt/bin/external/llvm-project/mlir/_virtual_includes/ArithCanonicalizationIncGen -Ibazel-out/darwin-opt/bin/external/llvm-project/mlir/_virtual_includes/AsmParserTokenKinds -Ibazel-out/darwin-opt/bin/external/llvm-project/mlir/_virtual_includes/MLIRShapeCanonicalizationIncGen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/base -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/base_attr_interfaces_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/broadcast_utils -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_ops -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_attrs_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/chlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_type_inference -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_assembly_format -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_ops_structs_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_structured_interface -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_structured_interface_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_attrdefs_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_dialect_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lhlo_gpu_ops_ops -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_passes -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/chlo_legalize_to_hlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/chlo_legalize_to_hlo_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_chlo_to_hlo_op -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/hlo_legalize_to_stablehlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_stablehlo_to_hlo_op -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_ops -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_attrs_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_enums_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_ops_inc_gen -Ibazel-out/darwin-opt/bin/external/stablehlo/_virtual_includes/stablehlo_types_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/legalize_to_linalg_utils -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_mhlo_to_scalar_op -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/legalize_to_standard_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/lower_complex_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/map_hlo_to_lhlo_op -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_pass_inc_gen -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_rng_utils -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/mhlo_scatter_gather_utils -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/shape_component_analysis -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/stablehlo_legalize_to_hlo -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/type_conversion -Ibazel-out/darwin-opt/bin/external/local_xla/xla/mlir_hlo/_virtual_includes/unfuse_batch_norm -isystem external/eigen_archive -isystem bazel-out/darwin-opt/bin/external/eigen_archive -isystem external/eigen_archive/mkl_include -isystem bazel-out/darwin-opt/bin/external/eigen_archive/mkl_include -isystem external/ml_dtypes -isystem bazel-out/darwin-opt/bin/external/ml_dtypes -isystem external/ml_dtypes/ml_dtypes -isystem bazel-out/darwin-opt/bin/external/ml_dtypes/ml_dtypes -isystem external/nsync/public -isystem bazel-out/darwin-opt/bin/external/nsync/public -isystem external/llvm-project/llvm/include -isystem bazel-out/darwin-opt/bin/external/llvm-project/llvm/include -isystem external/llvm-project/mlir/include -isystem bazel-out/darwin-opt/bin/external/llvm-project/mlir/include -isystem external/farmhash_archive/src -isystem bazel-out/darwin-opt/bin/external/farmhash_archive/src -isystem $PREFIX/include -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/tensorflow-split-2.16.1 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -D_FORTIFY_SOURCE=2 -isystem $PREFIX/include -mmacosx-version-min=10.13 -mmacosx-version-min=10.13 -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/tensorflow-split-2.16.1 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -D_FORTIFY_SOURCE=2 -isystem $PREFIX/include -mmacosx-version-min=10.13 -mmacosx-version-min=10.13 -DGRPC_BAZEL_BUILD -w -std=c++17 -c external/local_xla/xla/translate/mhlo_to_hlo/mlir_hlo_to_hlo.cc -o bazel-out/darwin-opt/bin/external/local_xla/xla/translate/mhlo_to_hlo/_objs/mlir_hlo_to_hlo/mlir_hlo_to_hlo.pic.o
[8,610 / 12,407] checking cached actions

So the -w is definitely there (towards the end, next to -std=c++17). This sounds like a clang bug...?

I see a couple of upstream issues around -Wc++11-narrowing, but a lot of them are very old. I suggest we try this again with clang 18, and if it still reproduces, I'll raise an issue upstream.

ngam commented 2 months ago

@h-vetinari, still same problem. Here's a full gist: https://gist.github.com/ngam/33c08e4f38f8760ae1907425361c872d

h-vetinari commented 2 months ago

@h-vetinari, still same problem. Here's a full gist: https://gist.github.com/ngam/33c08e4f38f8760ae1907425361c872d

Thank you! Are you sure it's the right one though? I kind of doubt that your local path is also /Users/uwe/... 😆

ngam commented 1 month ago

Major oops! Updated in-place 😸

h-vetinari commented 1 month ago

@ngam @xhochy, I applied the workaround suggested upstream, could you try again to see if the build now passes? 🙏

xhochy commented 1 month ago

With the last commit, it passed for me on osx-64.

h-vetinari commented 1 month ago

With the last commit, it passed for me on osx-64.

Thank you for fixing my braino and for testing - great news! 🙏 🥳

Can you and/or @ngam build out the osx{-64,-arm64} matrix?

h-vetinari commented 1 month ago

PS. If you restarted one of the linux builds, there's been no change for those since https://github.com/conda-forge/tensorflow-feedstock/pull/385/commits/bf7445a5f5cd56169ec28685d1cc3b8db35d14ce, where they all passed. All that was left was fixing osx.

ngam commented 1 month ago

Sorry for going disappearing (usg stuff/work) but I can start building Friday when I'm back to home base

xhochy commented 1 month ago

I can start to build osx-64 today and probably osx-arm64 maybe tonight or tomorrow.

xhochy commented 1 month ago

osx-arm64-logs.zip

xhochy commented 1 month ago

osx-64-logs.zip