Removed leptonica restrictions on Win

conda-forge / tesseract-feedstock

A conda-smithy repository for tesseract.

BSD 3-Clause "New" or "Revised" License

5 stars 17 forks source link

Removed leptonica restrictions on Win #41

Closed joseavegaa closed 1 year ago

joseavegaa commented 2 years ago

Removed leptonica version restriction on Windows, as the newest version available on conda-forge is 1.82.0 for Windows, and should be supported by tesseract if compiled with it.

@ conda-forge-admin, please render

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

izahn commented 2 years ago

Thanks for working on this! Leptonica is pinned on Windows just because I couldn't get it working with the latest Leptonica build. See https://github.com/conda-forge/tesseract-feedstock/pull/30 and https://github.com/conda-forge/tesseract-feedstock/pull/31 for some history.

If you can get it working that will be great!

joseavegaa commented 2 years ago

Thanks! I’ve been trying to build it using the automated pipeline, but haven’t quite get it working just yet.

I’ll try to make it work consistently on all platforms, and then I’ll mark this PR as ready for review.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [31, 45, 62]

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

There are too few lines. There should be one empty line at the end of the file.
If python is a host requirement, it should be a run requirement.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [45, 63]

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

joseavegaa commented 1 year ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GutHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/tesseract-feedstock/actions/runs/3258073088.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

joseavegaa commented 1 year ago

@conda-forge-admin, please rerender

joseavegaa commented 1 year ago

@conda-forge-admin, please rerender

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pkgw commented 1 year ago

This was rolled up into #50 (after I fixed some things about the Leptonica package).