search

conda-forge / tiledb-feedstock

A conda-smithy repository for tiledb.
BSD 3-Clause "New" or "Revised" License
2 stars 14 forks source link

Remove lz4-fix.patch #315

Closed jdblischak closed 8 hours ago

jdblischak commented 1 month ago

After the next release of TileDB, we need to remove the patch lz4-fix.patch

xref: https://github.com/TileDB-Inc/conda-forge-nightly-controller/issues/108#issuecomment-2236234946, https://github.com/TileDB-Inc/conda-forge-nightly-controller/pull/110, https://github.com/TileDB-Inc/conda-forge-nightly-controller/issues/111

cc: @teo-tsirpanis

jdblischak commented 1 month ago

@teo-tsirpanis Does removing the patch lz4-fix.patch require the upstream PR https://github.com/TileDB-Inc/TileDB/pull/5021? If that is the case, then I assume we need to keep the patch for now since that PR wasn't included in 2.25.0

teo-tsirpanis commented 1 month ago

Yes, we will remove the patch in 2.26.

jdblischak commented 8 hours ago

Closed by https://github.com/conda-forge/tiledb-feedstock/commit/5b65e096587b48486e57b19735513e3b33e0cc51 from #344. Thanks @teo-tsirpanis!