conda-forge / torchvision-feedstock

A conda-smithy repository for torchvision.
BSD 3-Clause "New" or "Revised" License
2 stars 16 forks source link

Rebuild for CUDA 11.8 w/arch support #84

Closed regro-cf-autotick-bot closed 10 months ago

regro-cf-autotick-bot commented 10 months ago

This PR has been triggered in an effort to update cuda118.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7013543937, please use this URL for debugging.

conda-forge-webservices[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 10 months ago

Think we need to add a CUDA 11.8 case (like this one from PyTorch) to this branch logic

https://github.com/conda-forge/torchvision-feedstock/blob/43854d5b850b1bc857240590aa2f092faf2fdbfd/recipe/build-torch.sh#L17-L22

hmaarrfk commented 10 months ago

Are you able to comment on https://github.com/conda-forge/tensorflow-feedstock/issues/296

i hit the issue with the cuda118 and unclear how it might be related (if at all)

jakirkham commented 10 months ago

Don't think it is CUDA 11.8 specific (IOW CUDA 11.2 would have the same issue), but it does look to be a bug in how the cudatoolkit package (used in CUDA 11 and before) is structured. Have responded in that issue ( https://github.com/conda-forge/tensorflow-feedstock/issues/296#issuecomment-1829194813 ) and raised a cudatoolkit issue ( https://github.com/conda-forge/cudatoolkit-feedstock/issues/96 )

The CUDA 12 packages are structured better. So wouldn't expect this issue there (would be interested to know whether that proves out though)

hmaarrfk commented 10 months ago

since the .ci_support files of 11.2 didn't change, I don't think we need a build number bump

jakirkham commented 10 months ago

Thanks Mark! 🙏

Dropped some outdated skips noted above

Would it be alright to add the automerge label here?

github-actions[bot] commented 10 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!