Open regro-cf-autotick-bot opened 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
@conda-forge/core, I mostly revived this feedstock, but I'm not sure if we actually want to do that (hasn't been built in 3 years).
Some immediate issues:
pytrilinios
which packages exactly the same thing, only with python bindings on top (at least the metadata forbids co-installation, but that's not a good setup)libkokkos{algorithms,containers,core,kernels,tsqr}.so
) than we have available in conda-forge (kokkos-kernels has libkokkoskernels.so
, and kokkos has libkokkos{algorithms,containers,core}
).
Any thoughts?
CC @conda-forge/kokkos @conda-forge/kokkos-kernels
Some immediate issues:
- it conflicts with
pytrilinios
which packages exactly the same thing, only with python bindings on top (at least the metadata forbids co-installation, but that's not a good setup)
I'm not familiar with Trilinos, but it sounds like the Trilinos feedstock should build the shared libraries, to be consumed by pytrilinios
. Once this feedstock supports all platforms that pytrilinios
does, the pytrilinios
recipe could likely be greatly simplified.
- it vendors kokkos, but more of it (
libkokkos{algorithms,containers,core,kernels,tsqr}.so
) than we have available in conda-forge (kokkos-kernels haslibkokkoskernels.so
, and kokkos haslibkokkos{algorithms,containers,core}
).
Again, not familiar with Trilinos, but after having a quick look at the repo it seems that TSQR is a solver written with Kokkos, but it is not part of the Kokkos ecosystem. The CMake lists simply declare the library as kokkostsqr
. The Kokkos feedstocks likely have enough support to build Trilinos at the moment.
- though it isn't obvious, at least the vendored kokkos corresponds to a tagged version (in this case 3.6.0)
If needed, we could build Kokkos and Kokkos-kernels 3.6.0 in their respective feedstocks.
- many other things being vendored
Seems like this is almost the point of this library.
- the list of libraries it contains is huge (see below), I haven't verified if all of those are conflict-free (gtest definitely isn't, for example).
Ideally, we want to build in separate feedstocks whatever is external (e.g. Kokkos) and then pull it here during build. If the rest builds within the CF env, than the rest should not conflict.
I would suggest starting with minimal platforms and build:
Then go back up that list turning on options.
We already have published a build of kokkos 3.6.01 which should be API/ABI compatible. In fact, I believe that any kokkos >=3.6.0,<4 should be compatible.
Looks like these trilinos packages were both created in 2017 by the same user, then adopted in 2020 by a new maintainer, but then haven't been touched since that same year. I would consider these feedstocks abandoned as they are already mentioned here: https://github.com/conda-forge/conda-forge.github.io/issues/1724
https://github.com/conda-forge/staged-recipes/pull/4004 https://github.com/conda-forge/staged-recipes/pull/3361
This PR has been triggered in an effort to update boost_cpp_to_libboost.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6389589558, please use this URL for debugging.