typer 0.3.2, recipe updates, pip check, add maintainer

conda-forge / typer-feedstock

A conda-smithy repository for typer.

BSD 3-Clause "New" or "Revised" License

0 stars 7 forks source link

typer 0.3.2, recipe updates, pip check, add maintainer #4

Closed bollwyvl closed 3 years ago

bollwyvl commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Notes

alternative to #3
adds pins for dependencies
adds pip check
minor metadata updates
adds self as maintainer :wave:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bollwyvl commented 3 years ago

@conda-forge/typer ready for review!

dfornika commented 3 years ago

@bollwyvl It's been a while since I merged an update for a conda package. On the bioconda project, there is a bot that can be called upon to perform the merge.

I checked the conda-forge docs but didn't find any instructions for merging. Can I just click the 'Merge pull request' button?

bollwyvl commented 3 years ago

Thanks for the speedy review!

Yeah, you can just push the big button... I don't see it in the services docs.

One can add automerge, but I only feel comfortable with that when the tests are running under coverage with a (high) threshold. It's caused a bunch of problems, when "big" packages go and change stuff on point releases, etc. not caught by pip check or whatever.

The typer tests are in-dist, so that could be reasonable here, but I couldn't get the claimed :100: % (probably because windows), more like 83%.